compilation: stop pinning aiecc to one thread - #185
Open
atassis wants to merge 1 commit into
Open
Conversation
Both aiecc rules defaulted AIECC_JOBS to 1, so every design's per-core compiles ran serially. On the encoder-MHA design (24 cores) that is 7.7 s against 6.0 s at aiecc's own auto-detect; nothing above 8 helps. -j does not change the output: insts.bin and all 24 per-core ELFs are byte-identical between -j1 and -j16.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both aiecc rules default
AIECC_JOBSto1:so every design's per-core compiles run one at a time, whatever the machine has. aiecc's own default
is auto-detect, and nothing here explains the override.
Fix
Default to
0, which is aiecc's auto-detect. The environment variable still overrides, so anyone whowants one thread keeps it.
Test
On a 24-core design (
StaticMHA, 20 heads, 8 pipelines): aiecc goes from 7.7 s to 6.0 s. Nothingabove 8 threads helps.
-jdoes not change what aiecc produces, so this is safe rather than a trade:insts.binand all 24per-core ELFs are byte-identical between
-j1and-j16, andinput_with_addresses.mlirdiffersonly in the work-dir path it embeds — which two runs at the same
-jalso differ in.