Repository navigation
Save content drafts and write structured data - #4
Open
Alt-Charlie wants to merge 9 commits into
Open
Alt-Charlie wants to merge 9 commits into
Alt-Charlie wants to merge 9 commits into
Conversation
Purge the whole cache when a post type's default is stored, keep the text of password protected posts out of printed markup, test the options page path against real ACF with a stand-in for ACF PRO's options pages, remove stored structured data on uninstall, and document drafts and structured data.
A loop asks for the variables of up to 50 posts on every page view the cache does not answer, and each post's excerpt, featured image, author and Yoast description were worked out whether the block used them or not.
A signed request has no user, so drafts were saved with no author: no byline once published, and an empty author_name in their structured data.
# Conflicts: # README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saves content drafts from Altimiser as unpublished posts, with the Markdown body converted to blocks, and prints JSON-LD stored per post or per post type, rendering plain
{{ variable }}values and one collection loop./healthnow lists post types, single line text fields on ACF PRO options pages and the variables a block can use. From review: a new draft belongs to the first administrator unlessaltimiser_draft_authornames someone else, and only the variables a block names are worked out.https://linear.app/alt-design/issue/DEV-9478
Testing: 358 tests pass locally on PHP 8.4 and 8.1.
Risk: a post type's default prints on every post of that type as soon as it is stored.
/healthsends the values of single line text fields on ACF options pages to Altimiser, as the protocol asks of every receiver, leaving out any field named or labelled like a key, token, secret or password.How to revert: revert the merge commit. Based on #3.