Repository navigation
Prepare the plugin for its first client trial - #2
Open
Alt-Charlie wants to merge 6 commits into
Open
Alt-Charlie wants to merge 6 commits into
Alt-Charlie wants to merge 6 commits into
Conversation
…ealth Appliers share an interface so alt text, links, robots.txt and structured data can each have one, and /health assembles its checks from them. One that throws is left out rather than stopping the answer. Classes now load on demand, and the test database can be named and placed through the environment.
Releases only publish once the tests pass and the tag is on main, and the workflow parses again. Page caches are purged for the pages that changed rather than whole, where the cache plugin can do that, and the altimiser_purge_urls action lets a host or edge cache be purged too. The secret has to be at least 32 characters, and can come from the environment or a settings page as well as wp-config.php, which gives each site on a network its own. Refused signed requests and failed writes are logged. A fault in Yoast no longer stops /health answering, and the tests also run against Yoast 24.0, the oldest release supported. Only posts whose type has public pages are written to, so a menu item answering ?p=N under plain permalinks is left alone. The review count waits two seconds at most and is asked for by one page at a time, and the widget shows what is approved and what Altimiser can fix here. Admin text is translatable, the queue's styles are enqueued, and uninstalling removes what the plugin keeps.
…y request An option saved without saying otherwise is autoloaded, which puts the secret in the object cache and every option dump. It is now marked not to autoload whenever it is added or updated, from the settings page or anywhere else.
Follows the protocol's authorisation code flow: Connect sends the editor to Altimiser's signed /connect link, the code that comes back is exchanged for a token kept encrypted against the editor on this site, and review links carry the connection and a second signature made with that token. Counts on the menu and the dashboard wait until the editor has connected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives each kind of change its own applier, reports site setup (search engines discouraged, plain permalinks) on
/health, adds a settings page for the secret and the Altimiser address, and a release workflow that publishes only after the tests pass and the tag matches the plugin's version. From review: each page cache is purged on its own, so one that throws no longer stops the others, and the settings option is kept out of autoload. Each editor now connects their own Altimiser account before the review queue or its counts show, through the protocol's/connectflow, with the token kept encrypted against them.https://linear.app/alt-design/issue/DEV-9669
Testing: 223 tests pass locally on PHP 8.4 and 8.1 with Yoast SEO 28.8. This is their first run on GitHub Actions.
Risk: a site already connected behaves as before. A secret saved on the settings page stops autoloading from its next save. Editors already using the review queue have to connect once before it shows again.
How to revert: revert the merge commit. DEV-9477 and DEV-9478 are stacked on this branch.