Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the control panel page into Alt Tools → SEO, a dropdown shared with the other Alt addons, and switches its icons to Statamic's own set so they match the core nav. Query Strings becomes its own page in the group, as Redirect query strings, because Statamic allows one level of children. Part of DEV-9627.
Testing: New NavTest fails on main and passes here. Full suite: 99 pass; the four unicode redirect tests fail on main too and are unrelated. Installed from this branch into a Statamic 6.40 site with the other eight Alt addons: the page sits in its group, loads, and its icons render.
Risk: Low. The nav item moves, so a saved nav customisation that referenced it stops matching it.
How to revert: revert this PR, and the item goes back to Tools with its old icon.