Repository navigation
Extend C-328 to the full-response http family on the stock WASI 0.3 component - #133
Merged
Merged
Conversation
…omponent, and pin the empty-body request framing on p3 Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs almide/almide#1710 (ADR-0023 step 4)
ADR-0023 step 4 serves the six
*_responsefunctions in the p3 shim overwasi:http. This is the route the ADR chose; als#131 described a host-op route, which als#132 withdrew.Changes
get_header, every value of a repeated field in order, the lowercased header set, the body, and a failure's text.content-length: 0unless the method is GET or HEAD. Without it, the host framed an empty PATCH or DELETE as chunked0\r\n\r\nwhere native sends no content.Evidence
tests/http_response_cross_test.rsruns every verb plus a plain empty PATCH against a loopback server. It requires identical stdout and exit codes from native and fromwasmtime run -S http=yon the component.🤖 Generated with Claude Code