Repository navigation
Drop a screen's frame before its surface - #37
Merged
Merged
Conversation
…urface: closing it no longer panics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a window whose screen still held the frame being recorded panicked in wgpu (
Surface[Id(0,1)] does not exist). Struct fields drop in order, so the surface went before theSurfaceTexturetaken from it. Movingframefirst fixes it.Checked with a two-window program that closes window 1 right after drawing into it: main panics, and this branch goes on drawing window 2.