Repository navigation
Conversation
… macOS inner_size leaves out a title bar that full screen hides, so drawing and the pointer disagreed by its height
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS winit's
inner_size()iscontentRectForFrameRect(frame), which in full screen still subtracts the title bar that is hidden there. The surface is sized fromResized(the view's frame), so a program laying out withheight()drew to a shorter height than the view, and pointer positions (measured in the view) landed below what was drawn under them.width()/height()now return the size of the lastResized(the creation size before any), the same size the surface is configured to.