fix: pin click<8.2 to unbreak ray CLIPatch 1 - #477
Open
XiangyiWang2 wants to merge 2 commits into
Open
Conversation
HuangJoJo
reviewed
Aug 6, 2026
| @@ -1,4 +1,5 @@ | |||
| ray[default,cgraph]==2.48.0 # vllm required ray[default,cgraph]>=2.48.0 | |||
| click<8.2 # ray 2.48.0 CLI breaks on click>=8.2: deepcopy of click's Sentinel enum raises ValueError | |||
Author
|
I have complete signing,Thank you!
获取 Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
发件人: CLAassistant ***@***.***>
发送时间: Saturday, 01 August 2026 10:46:25
收件人: alibaba/ROLL ***@***.***>
抄送: Xiangyi Wang (SDS,123090576) ***@***.***>; Author ***@***.***>
主题: Re: [alibaba/ROLL] fix: pin click<8.2 to unbreak ray CLIPatch 1 (PR #477)
You don't often get email from ***@***.*** Learn why this is important<https://aka.ms/LearnAboutSenderIdentification>
[https://avatars.githubusercontent.com/u/11571300?s=20&v=4]CLAassistant left a comment (alibaba/ROLL#477)<#477 (comment)>
[CLA assistant check]<https://cla-assistant.io/alibaba/ROLL?pullRequest=477>
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement<https://cla-assistant.io/alibaba/ROLL?pullRequest=477> before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck<https://cla-assistant.io/check/alibaba/ROLL?pullRequest=477> it.
―
Reply to this email directly, view it on GitHub<#477?email_source=notifications&email_token=BJAPZUKB6WRXVDBZA267WEL5HVKYDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJUHEZTONJYGEZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5149375813>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BJAPZULHN4PLGJPGZYRIL6T5HVKYDAVCNFSNUABFKJSXA33TNF2G64TZHM4TSMJZGM4TANBZHNEXG43VMU5TKMBTGQ4DONJRGUY2C5QC>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS<https://github.com/notifications/mobile/ios/BJAPZUMZERNZQEYQFDV5QT35HVKYDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJUHEZTONJYGEZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android<https://github.com/notifications/mobile/android/BJAPZUI6GCQZMUZCH5WOS5D5HVKYDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJUHEZTONJYGEZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today!
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A fresh install per
requirements_torch280_vllm.txtleaves therayCLI completely broken — everyraycommand fails at import time:requirements_common.txtpinsray==2.48.0but leavesclickunconstrained, so pip resolves click 8.4.x. Ray 2.48's CLI callscopy.deepcopy()on click command objects at module import time (add_command_aliasinray/scripts/scripts.py), which fails on click>=8.2 whereSentinelbecame an enum —enum.__new__rejects the dynamically created sentinel object during reconstruction.Repro
Fresh conda env (Python 3.10.20), install per
requirements_torch280_vllm.txt, then run any ray command, e.g.ray start --head.Full traceback
Fix
Pin
click<8.2inrequirements_common.txt, right below theraypin it belongs to.Verified with click 8.1.8 on the same env —
ray start --headandray statusboth work again.Note
This is a workaround for an upstream ray/click incompatibility; the pin can be removed once ray supports click>=8.2. The env dump in #379 shows click 8.2.1, already past the breaking version.