Skip to content

fix(glue): skip only the corrupted line of the start log (Refs #768) - #773

Merged
alex-mextner merged 2 commits into
mainfrom
fix/768-start-log-utf8
Nov 18, 2026
Merged

alex-mextner merged 2 commits into
mainfrom
fix/768-start-log-utf8

Conversation

@alex-mextner

Copy link
Copy Markdown
Owner

One invalid UTF-8 line in the glue start log no longer drops the whole fallback count: lines are read as bytes and decoded one at a time, so only the bad line is skipped. Regression test included.

Refs #768

@alex-mextner
alex-mextner force-pushed the fix/768-start-log-utf8 branch from 4122f07 to 9498932 Compare November 18, 2026 11:17
@alex-mextner

Copy link
Copy Markdown
Owner Author

Acceptance proof for #768 (branch head of this PR):

# #768 proof 2026-11-18T13:23:19+01:00 at 9498932e
$ log: 5 valid starts around one invalid UTF-8 line
b'{"at": 1}\n{"at": 2}\n{"at": 3}\n\x80\x81\xff\n{"at": 4}\n{"at": 5}\n'
starts_since = 5
$ pytest regression
======================= 2 passed, 83 deselected in 0.14s =======================

CI full suite green: https://github.com/alex-mextner/3d-cli/actions/runs/44293304516

@alex-mextner
alex-mextner merged commit bd0757e into main Nov 18, 2026
11 checks passed
@alex-mextner
alex-mextner deleted the fix/768-start-log-utf8 branch November 18, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant