Repository navigation
fix(glue): skip only the corrupted line of the start log (Refs #768) - #773
Merged
Merged
Conversation
2 tasks
alex-mextner
force-pushed
the
fix/768-start-log-utf8
branch
from
November 18, 2026 11:17
4122f07 to
9498932
Compare
Owner
Author
|
Acceptance proof for #768 (branch head of this PR): CI full suite green: https://github.com/alex-mextner/3d-cli/actions/runs/44293304516 |
Closed
2 tasks done
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One invalid UTF-8 line in the glue start log no longer drops the whole fallback count: lines are read as bytes and decoded one at a time, so only the bad line is skipped. Regression test included.
Refs #768