Repository navigation
fix(mcp): Make get_default_cloud_context verification flag and hints agree - #1380
Merged
Aaron ("AJ") Steers (aaronsteers) merged 1 commit intoOct 16, 2026
Conversation
… hint default_workspace_verified is now None when no default workspace ID was resolved, so the output never claims an unset default is valid or unverifiable. When the session falls back to a configured workspace but the user profile stores no default, the discovery hint now says exactly that instead of claiming no default workspace is set. Co-Authored-By: AJ Steers <[email protected]>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1792014124-default-context-verified-wording' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1792014124-default-context-verified-wording'PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful ResourcesCommunity SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
Airbyte Support Bot (airbyte-support-bot)
requested a balanced review from Copilot
October 14, 2026 21:57
Copilot started reviewing on behalf of
Airbyte Support Bot (airbyte-support-bot)
October 14, 2026 21:58
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes consistently handle nullable verification across the client and MCP models, with no unresolved findings.
0 open findings
What changed in this PR
Aligns default Cloud workspace verification and hints across the client and MCP response.
Changes:
- Returns
nullverification when no default workspace ID is resolved. - Distinguishes session-configured workspaces from stored profile defaults in hints.
- Adds tests for missing and session-configured defaults.
| File | Description |
|---|---|
| tests/unit_tests/test_cloud_client.py | Tests nullable verification and configured-workspace hints. |
| airbyte/mcp/cloud.py | Allows nullable verification in MCP responses. |
| airbyte/cloud/models.py | Allows and documents nullable verification. |
| airbyte/cloud/client.py | Aligns verification values and default-workspace hints. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Code coverage overviewLanguages: Python Python / code-coverage/pytest-no-creds
View coverage of the 10 most impacted files.
Python / code-coverage/pytest
View coverage of the 10 most impacted files.
Python / code-coverage/pytest-unit
Line coverage data for the release-candidate/v1 branch is not yet available. View coverage of the 10 most covered files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
Aaron ("AJ") Steers (aaronsteers)
marked this pull request as ready for review
October 16, 2026 00:06
Aaron ("AJ") Steers (aaronsteers)
merged commit Oct 16, 2026
47192c8
into
release-candidate/v1
33 of 34 checks passed
Aaron ("AJ") Steers (aaronsteers)
deleted the
devin/1792014124-default-context-verified-wording
branch
October 16, 2026 00:07
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
👉 TL;DR: The default-context tool could say "No default workspace is set" and at the same time report the default workspace as verified. It no longer reports verified or unverified when there is nothing to verify, and its hint now explains when the session uses a configured workspace but the user profile has no default.
Specifically,
default_workspace_verifiedbecomesbool | NoneonCloudDefaultContextInfoandCloudDefaultContextResult, andCloudClient._missing_default_workspace_hint()picks the hint text.Changes
default_workspace_verifiedisNonewhen no default workspace ID was resolved.defaultWorkspaceId, the hint says: "Your Airbyte user profile has no default workspace; this session uses the configured workspace . ..."Risks
default_workspace_verifiedcan now benull.Follow-ups
member_organizations. That list comes only from explicit org permissions, while the default org is derived from workspace access.Test plan
Link to Devin session: https://app.devin.ai/sessions/a51d808f26c9402fafc93e7640648187
Open in Devin Desktop: https://app.devin.ai/desktop/session/a51d808f26c9402fafc93e7640648187?variant=devin
Requested by: Aaron ("AJ") Steers (@aaronsteers)