Repository navigation
fix(mcp): Say "no sync jobs yet" in get_cloud_sync_logs for connections with no jobs - #1378
Merged
Aaron ("AJ") Steers (aaronsteers) merged 1 commit intoOct 16, 2026
Conversation
get_cloud_sync_logs raised a generic 'resource does not exist' error when no job_id was given and the connection had never synced. It now tells the caller the connection has no sync jobs and points them at run_cloud_sync. Co-Authored-By: AJ Steers <[email protected]>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1792013985-sync-logs-no-jobs-message' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1792013985-sync-logs-no-jobs-message'PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful ResourcesCommunity SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
Airbyte Support Bot (airbyte-support-bot)
requested a balanced review from Copilot
October 14, 2026 21:57
Copilot started reviewing on behalf of
Airbyte Support Bot (airbyte-support-bot)
October 14, 2026 21:58
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change preserves explicit-job behavior and includes regression coverage, with no blocking issues identified.
0 open findings
What changed in this PR
Improves MCP sync-log errors for connections with no sync history.
Changes:
- Adds a “no sync jobs yet” message with guidance to use
run_cloud_sync. - Adds regression coverage for the new message and unchanged explicit-job lookup behavior.
| File | Description |
|---|---|
tests/unit_tests/test_mcp_cloud.py |
Tests both missing-job error cases. |
airbyte/mcp/cloud.py |
Adds actionable guidance when no sync jobs exist. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Code coverage overviewLanguages: Python Python / code-coverage/pytest-no-creds
View coverage of the 10 most impacted files.
Python / code-coverage/pytest
View coverage of the 10 most impacted files.
Python / code-coverage/pytest-unit
Line coverage data for the release-candidate/v1 branch is not yet available. View coverage of the 10 most covered files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
Aaron ("AJ") Steers (aaronsteers)
marked this pull request as ready for review
October 16, 2026 00:05
Aaron ("AJ") Steers (aaronsteers)
merged commit Oct 16, 2026
95d2e1a
into
release-candidate/v1
33 of 34 checks passed
Aaron ("AJ") Steers (aaronsteers)
deleted the
devin/1792013985-sync-logs-no-jobs-message
branch
October 16, 2026 00:05
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
👉 TL;DR: Asking for sync logs on a connection that has never run a sync used to say the resource does not exist. It now says the connection has no sync jobs yet and suggests running a sync first.
Specifically,
get_cloud_sync_logswithjob_id=Noneand no sync history now raisesAirbyteMissingResourceErrorwith"Connection '<id>' has no sync jobs yet."and guidance pointing torun_cloud_sync.Changes
job_idisn't found, the behavior is unchanged.Test plan
Link to Devin session: https://app.devin.ai/sessions/a51d808f26c9402fafc93e7640648187
Open in Devin Desktop: https://app.devin.ai/desktop/session/a51d808f26c9402fafc93e7640648187?variant=devin
Requested by: Aaron ("AJ") Steers (@aaronsteers)