Skip to content

fix(mcp): Request English intent metadata - #1376

Merged
Caleb Evans (calebevans-ab) merged 1 commit into
release-candidate/v1from
devin/1792000146-english-mcp-intents
Oct 14, 2026
Merged

Caleb Evans (calebevans-ab) merged 1 commit into
release-candidate/v1from
devin/1792000146-english-mcp-intents

Conversation

@calebevans-ab

@calebevans-ab Caleb Evans (calebevans-ab) commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

TL;DR: Ask models to write intent metadata in English while keeping user-facing replies in the user's preferred language.

  • Strengthen native Datadog intent schemas and server instructions; apply the same guidance to the explicit external API query/action parameters. Intents remain optional, and execution/capture behavior is unchanged.
  • Cover emitted MCP initialization instructions, tool schemas, and optionality with regression tests. The optional OpenTelemetry backend still uses upstream fastmcp-extensions and its existing English guidance; this PR does not change or replace that dependency.

Resolves AGENTIC-2345.

Validation

  • uv run pytest tests/unit_tests/test_mcp_datadog.py tests/unit_tests/test_mcp_cloud.py tests/unit_tests/test_mcp_otel.py -q: 260 passed.
  • uv run poe check: exit 0 (Ruff, Pyrefly, test collection).
  • uv run ruff format --check airbyte/mcp/_datadog.py airbyte/mcp/cloud.py tests/unit_tests/test_mcp_datadog.py tests/unit_tests/test_mcp_cloud.py: 4 files already formatted.
  • Local in-memory schemas + Claude Sonnet 4.6: the final three Spanish prompt samples produced English intents and Spanish replies. Used forced tool selection and mocked results; no Airbyte API calls. An earlier wording produced one Spanish intent, prompting the stronger “internal metadata / always English” wording.

This is guidance, not enforcement or a statistical compliance benchmark. The existing instruction to omit argument values remains best-effort too; one sample copied a synthetic connector identifier.

Link to Devin session: https://app.devin.ai/sessions/cc604bbd480d46c7ad8683aba94738bd
Open in Devin Desktop: https://app.devin.ai/desktop/session/cc604bbd480d46c7ad8683aba94738bd?variant=devin
Requested by: Caleb Evans (@calebevans-ab)

Important

Auto-merge enabled.

This PR is set to merge automatically when all requirements are met.

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@linear-code

linear-code Bot commented Oct 14, 2026

Copy link
Copy Markdown

AGENTIC-2345

@github-actions

Copy link
Copy Markdown

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

Testing This PyAirbyte Version

You can test this version of PyAirbyte using the following:

# Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1792000146-english-mcp-intents' pyairbyte --help

# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1792000146-english-mcp-intents'

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /fix-pr - Fixes most formatting and linting issues
  • /uv-lock - Updates uv.lock file
  • /test-pr - Runs tests with the updated PyAirbyte
  • /prerelease - Builds and publishes a prerelease version to PyPI
📚 Show Repo Guidance

Helpful Resources

Community Support

Questions? Join the #pyairbyte channel in our Slack workspace.

📝 Edit this welcome message.

@calebevans-ab
Caleb Evans (calebevans-ab) marked this pull request as ready for review October 14, 2026 17:59
@calebevans-ab

Copy link
Copy Markdown
Contributor Author

Codex (@codex) review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T18:01:32.841775Z e854c26 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-code-quality

github-code-quality Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Code coverage overview

Languages: Python

Python / code-coverage/pytest-no-creds

release-candidate/v1 d9f652f devin/1792000146-eng... e854c26 +/-
65% 79% +14%
View coverage of the 10 most impacted files.
File release-candidate/v1 d9f652f devin/1792000146-eng... e854c26 +/-
airbyte/mcp/cloud.py 52% 83% +31%
airbyte/_util/api_util.py 36% 68% +32%
airbyte/cloud/connectors.py 34% 75% +41%
airbyte/mcp/_datadog.py 0% 50% +50%
airbyte/mcp/_user_identity.py 0% 93% +93%
airbyte/_direct...ctors/models.py 0% 94% +94%
airbyte/mcp/_telemetry.py 0% 94% +94%
airbyte/mcp/_sso_auth.py 0% 96% +96%
airbyte/cloud/models.py 0% 97% +97%
airbyte/mcp/int...nc_status_ui.py 0% 97% +97%

Python / code-coverage/pytest

release-candidate/v1 d9f652f devin/1792000146-eng... e854c26 +/-
71% 81% +10%
View coverage of the 10 most impacted files.
File release-candidate/v1 d9f652f devin/1792000146-eng... e854c26 +/-
airbyte/cloud/connectors.py 51% 80% +29%
airbyte/mcp/cloud.py 52% 83% +31%
airbyte/mcp/_datadog.py 0% 50% +50%
airbyte/mcp/int..._registry_ui.py 0% 92% +92%
airbyte/mcp/_user_identity.py 0% 93% +93%
airbyte/_direct...ctors/models.py 0% 94% +94%
airbyte/mcp/_telemetry.py 0% 94% +94%
airbyte/mcp/_sso_auth.py 0% 96% +96%
airbyte/cloud/models.py 0% 97% +97%
airbyte/mcp/int...nc_status_ui.py 0% 97% +97%

Python / code-coverage/pytest-unit

release-candidate/v1 devin/1792000146-eng... e854c26 +/-
— 76% —

Line coverage data for the release-candidate/v1 branch is not yet available.

View coverage of the 10 most covered files.
File release-candidate/v1 devin/1792000146-eng... e854c26 +/-
airbyte/cloud/models.py — 97% —
airbyte/mcp/_sso_auth.py — 96% —
airbyte/_direct...ctors/models.py — 94% —
airbyte/cloud/client.py — 90% —
airbyte/exceptions.py — 89% —
airbyte/mcp/cloud.py — 83% —
airbyte/progress.py — 80% —
airbyte/cloud/connectors.py — 75% —
airbyte/_util/api_util.py — 68% —
airbyte/shared/...ql_processor.py — 68% —

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated October 14, 2026 18:09 UTC

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: e854c26d30

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

@calebevans-ab
Caleb Evans (calebevans-ab) merged commit 55917c3 into release-candidate/v1 Oct 14, 2026
33 checks passed
@calebevans-ab
Caleb Evans (calebevans-ab) deleted the devin/1792000146-english-mcp-intents branch October 14, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants