Repository navigation
fix(mcp): Request English intent metadata - #1376
Caleb Evans (calebevans-ab) merged 1 commit into
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1792000146-english-mcp-intents' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1792000146-english-mcp-intents'PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful ResourcesCommunity SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
|
Codex (@codex) review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Code coverage overviewLanguages: Python Python / code-coverage/pytest-no-creds
View coverage of the 10 most impacted files.
Python / code-coverage/pytest
View coverage of the 10 most impacted files.
Python / code-coverage/pytest-unit
Line coverage data for the release-candidate/v1 branch is not yet available. View coverage of the 10 most covered files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback". |
55917c3
into
release-candidate/v1
Summary
TL;DR: Ask models to write
intentmetadata in English while keeping user-facing replies in the user's preferred language.fastmcp-extensionsand its existing English guidance; this PR does not change or replace that dependency.Resolves AGENTIC-2345.
Validation
uv run pytest tests/unit_tests/test_mcp_datadog.py tests/unit_tests/test_mcp_cloud.py tests/unit_tests/test_mcp_otel.py -q: 260 passed.uv run poe check: exit 0 (Ruff, Pyrefly, test collection).uv run ruff format --check airbyte/mcp/_datadog.py airbyte/mcp/cloud.py tests/unit_tests/test_mcp_datadog.py tests/unit_tests/test_mcp_cloud.py: 4 files already formatted.This is guidance, not enforcement or a statistical compliance benchmark. The existing instruction to omit argument values remains best-effort too; one sample copied a synthetic connector identifier.
Link to Devin session: https://app.devin.ai/sessions/cc604bbd480d46c7ad8683aba94738bd
Open in Devin Desktop: https://app.devin.ai/desktop/session/cc604bbd480d46c7ad8683aba94738bd?variant=devin
Requested by: Caleb Evans (@calebevans-ab)
Important
Auto-merge enabled.
This PR is set to merge automatically when all requirements are met.