Repository navigation
Open
Labels
dependenciesPull requests that update a dependency filePull requests that update a dependency file
Description
Tracking issue for moving embassy-sync (and the two crates that follow it) back to crates.io releases.
Background
aimdb-embassy-adapter/src/buffer.rs polls Subscriber::poll_next_message and Receiver::poll_changed directly. Both are merged upstream but not in embassy-sync 0.8.0, still the latest on crates.io. The workspace therefore patches them in (Cargo.toml, [patch.crates-io], added in #343 for #341):
embassy-sync→ embassy git rev03c826fembassy-net-driver-channelandembassy-net-driver→ same rev. Publishedembassy-net-driver-channel0.4.0 calls the pre-guardzerocopy_channelAPI the patched embassy-sync no longer has, and its driver trait must be the same instanceembassy-netsees.
Consequences while the patch is in place:
- Publishing: patches are not published, so the packaged
aimdb-embassy-adaptercannot build itsembassy-syncfeature for a downstream user. The Makefile publishes it without verification (PUBLISH_NO_VERIFY) for this reason. The vendored copy carries the same0.8.0version as the registry release, so nothing flags the mismatch. - Other embassy bumps: pinning further embassy-* crates to git is constrained by this rev. E.g. pointing
embassy-stm32at03c826fto pick up theBufferedUartTX fix fails to resolve (embassy-time-driverconflict), see Serial demo client hangs against the NUCLEO-H563ZI until the board is rebooted once #382 / Drop the EmbassyUart flush-per-write workaround once embassy-stm32 ships the BufferedUart TX fix #385.
To do once a release carries both APIs
- Bump
embassy-syncin the workspaceCargo.tomland inaimdb-mqtt-connector/Cargo.toml(it declares its ownembassy-sync = "0.8.0"). - Remove the three
[patch.crates-io]entries and their comment; bumpembassy-net-driver-channel/embassy-net-driver(orembassy-net) to releases that match the new embassy-sync. - Drop
aimdb-embassy-adapterfromPUBLISH_NO_VERIFYin the Makefile and update its comment (it still points atmake publishis broken: three connectors are unpublished and a dev-dependency cycle blocks any ordering #242). - Update the comments that point at the patch (
aimdb-mqtt-connector/Cargo.toml,aimdb-embassy-adapter/src/buffer.rsaround thepoll_*calls). - Check whether this unblocks Drop the EmbassyUart flush-per-write workaround once embassy-stm32 ships the BufferedUart TX fix #385 (embassy-stm32 with the
BufferedUartfix) so both can move together. - Build the embedded targets (
make test-embeddedor equivalent) and smoke-test one Embassy demo on the NUCLEO-H563ZI.
Metadata
Metadata
Assignees
Labels
dependenciesPull requests that update a dependency filePull requests that update a dependency file
Activity