Repository navigation
perf: test bounded 128-row prompt matrices - #257
Closed
aien-spark wants to merge 4 commits into
Closed
aien-spark wants to merge 4 commits into
aien-spark wants to merge 4 commits into
Conversation
This was referenced Nov 1, 2026
aien-spark
added a commit
that referenced
this pull request
Nov 2, 2026
#259 #260) native-x86-host on this head hit its 40 min timeout (cancelled, not failed); the same code at 9ade9f5 (diff since: evidence JSON + .crumb only) passed it in 34 min, and main e6598c7 passes it. All 10 other checks green on the merge with main. Independent review APPROVE-WITH-NOTES (see PR comment).
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The corrected 128-row candidate preserves every output-score bit and next-token choice in all six frozen 27B reading cases. Its repeated 5,017-token read took 14.759 seconds versus 18.817 seconds in the 64-row comparison. These are shared-machine observations, not quiet-machine qualification. The 64-row default stays unchanged.
Checked Omega admission now uses the exact final store-offset bound and permits the experimental 128-row shape. The kernel opts into the existing extended register budget. The first full-model trial exposed an older cache-admission cap that rejected this declaration before launch; commit 572a73b makes the cache honor the explicit budget while retaining the default cap and hardware checks. The real cache regression fails against the old library and passes the correction, including missing-opt-in and over-budget refusals.
Validation: the earlier candidate passed all 77 host targets, matrix simulation and nine Omega source mutants. The corrected cache path passes the targeted suite and full-model exact-score comparison; the corrected full host rerun passed all 77 targets. The command and log digest are in om/prefill-shape/cache-full-host-validation.json. Original 64-row kernel bytes and resources were unchanged in ten representative cases. Evidence is in om/prefill-shape/large-shape-gpu-validation.json, cache-admission-regression.json and the earlier host receipts. Stacked on #252; work-order combination is #258. No merge, deployment or quiet performance qualification is claimed.
Apache-2.0 WITH LLVM-exception notices retained. No new production dependency.