Publish ActorTemplate golden snapshots as tags - #1523
Open
Eitan Yarmush (EItanya) wants to merge 1 commit into
Open
Publish ActorTemplate golden snapshots as tags#1523Eitan Yarmush (EItanya) wants to merge 1 commit into
Eitan Yarmush (EItanya) wants to merge 1 commit into
Conversation
Copy each warmed golden actor snapshot into a published tag before deleting the temporary actor. Resolve that tag as the default when creating actors, and use it for data-only golden restores. Clean up golden resources with their template and recover interrupted tag builds. Signed-off-by: Eitan Yarmush <[email protected]>
Eitan Yarmush (EItanya)
requested review from
Julian Gutierrez Oschmann (juli4n),
Luiz Oliveira (laoj2) and
Zoe Zhao (zoez7)
and removed request for
Luiz Oliveira (laoj2)
September 6, 2026 12:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1507
Golden snapshots currently remain owned by the temporary golden actor, so another resume/suspend cycle or actor deletion can collect a snapshot still referenced by its template. The controller now copies the warmed snapshot into a published tag, deletes the golden actor, and records the tag reference on the template. Interrupted tag creation and cleanup remain retryable; template deletion cleans up both resources.
CreateActorresolves an explicitsourceTagor the template's golden tag into the actor's initial snapshot. Actors created before the golden tag is ready retain their cold-boot behavior. The golden tag uses the template UID as its name inate-golden. The proto replacesgolden_snapshotwithgolden_tagat field 1, without backward compatibility.This PR is based directly on
mainand does not depend on #1521.Follow-up recommendation: move the create → resume → wait → suspend → tag → delete sequence into a golden-template workflow using the existing workflow conventions. The reconciler now coordinates multiple recoverable steps; it could retain scheduling and retries while delegating that sequence to the workflow. This refactor is outside this PR.
Validation: full
env -u NO_COLOR make verifypassed after rebasing ontomain. After the final proto field-number change, bindings were regenerated and the control API unit/functional tests plus proto-format and Go-format checks passed.