Skip to content

ci: fix the review smoke on Dependabot PRs and under SHA pinning - #96

Merged
jnsdls merged 2 commits into
mainfrom
ci/skip-review-smoke-on-dependabot
Oct 23, 2026
Merged

jnsdls merged 2 commits into
mainfrom
ci/skip-review-smoke-on-dependabot

Conversation

@jnsdls

@jnsdls jnsdls commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Two fixes for the review smoke, which fails on every pull request right now.

Unpinned setup-node in action.yml. #94 pinned the workflows but left actions/setup-node in action.yml on a tag. agent-labs-dev now requires SHA-pinned actions, so all three review jobs stop at that step. This pins it to the same v7.1.0 commit the workflows use. No uses: in the repo is left on a tag, apart from the local ./.

Dependabot PRs. A run that Dependabot triggers gets the Dependabot secrets, not the Actions secrets. OPENROUTER_API_KEY came through empty on #95 and the jobs exited with code 2 before testing anything. The jobs now skip when github.actor is dependabot[bot], the same way fork PRs already skip. I didn't copy the key into Dependabot secrets. A dependency bump has no app change to review, and the key would reach any code a bumped dependency runs.

Dependabot pins in action.yml get bumped by the existing github-actions config, since it scans /.

🤖 Generated with Claude Code

@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
bugpatrol Ready Ready Preview Oct 23, 2026 4:18pm UTC

Request Review

jnsdls and others added 2 commits October 23, 2026 09:17
A run that Dependabot triggers gets the Dependabot secrets, not the
Actions secrets, so OPENROUTER_API_KEY is empty and all three review
jobs fail before testing anything.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
#94 pinned the workflows but left action.yml on a tag. agent-labs-dev
now rejects unpinned actions, so the review smoke fails at the
setup-node step on every pull request.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@jnsdls
jnsdls force-pushed the ci/skip-review-smoke-on-dependabot branch from 044819d to c15a0b7 Compare October 23, 2026 16:17
@jnsdls jnsdls changed the title ci: skip the review smoke on Dependabot pull requests ci: fix the review smoke on Dependabot PRs and under SHA pinning Oct 23, 2026
@jnsdls
jnsdls merged commit 16e0c91 into main Oct 23, 2026
7 of 10 checks passed
@jnsdls
jnsdls deleted the ci/skip-review-smoke-on-dependabot branch October 23, 2026 16:45

This branch was successfully deployed

1 active deployment
Preview — c15a0b7c Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant