refactor: consume the extracted agent drivers - #2
Open
kreneskyp wants to merge 3 commits into
Open
Conversation
The drivers, transcript parsing, and sentinel constants moved to @agent-ix/agent-drivers, where they are also used by ticket-runner. Delete the copies here and import them instead. No compatibility re-exports: the driver surface is no longer part of this package's API, and leaving pass-throughs would keep two import paths alive for the same code. Consumers take it from @agent-ix/agent-drivers directly. The three tests covering the moved functions are removed rather than duplicated; agent-drivers covers that code at 100%. Sentinel literals are unchanged, so every task brief already in the wild — and ix-flow/evals and quoin/evals, which keep their own copies — keeps working. Build, lint, and tests green. Dependencies are local links while npm.ix is unreachable and must return to published ranges before release. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
The local links were a workaround for npm.ix being unreachable. Now that agent-drivers is published, every @agent-ix dependency resolves from the registry again. agent-drivers takes a -0 range because it only exists as a local snapshot (0.0.1-*) until it is released upstream. Co-Authored-By: Claude Opus 5 <[email protected]>
Phase 0 deleted the copied driver implementations but left a structurally identical AgentDriver declared here, so resolveDriver rejected the suite's own driver overrides — a type error that make build never surfaced because vite does not typecheck. EvalRunOptions is a superset of DriverOptions, so the package type slots in unchanged. Co-Authored-By: Claude Opus 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Drivers, transcript parsing, and sentinel constants were only reachable by importing this eval harness — but they are not eval-specific.
ticket-runnerneeds the same launch sequence and completion signals. They now live in@agent-ix/agent-drivers.What
src/drivers.ts,src/metrics.ts,src/sentinels.ts; import from the package instead.Sentinel literals are byte-identical, so task briefs already in the wild keep working — including
ix-flow/evalsandquoin/evals, which keep their own copies of the strings.Testing
Build, lint, and tests green.
link:../agent-drivers) because npm.ix is unreachable. They must return to published ranges before this merges. The remaining verification —make evalsgreen in ix-flow and quoin — needs a real agent and is not possible while the registry is down.🤖 Generated with Claude Code