fix: keep theme and language controls in settings - #772
Open
killersteps wants to merge 1 commit into
Open
Conversation
Appearance and locale already live in Settings > General. Drop the duplicate toolbar buttons so the chat chrome stays on the session, not on configuring the web UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The chat top bar had theme and language buttons next to session actions. Those same choices already exist in Settings → General (appearance: light / dark / system; language list).
The extra chrome pulls attention toward configuring the web UI instead of using the agent. On a short toolbar it also costs space that session actions need.
Solution
Remove the toolbar theme toggle, language menu, and the language dropdown panel. Settings → General is the single place to change appearance and locale.
Mobile overflow actions no longer include those two controls either.
Tests
components/AppShell.mobile-toolbar.test.mjs: toolbar source no longer mounts theme/language actions; remaining session actions still keep the overflow layer open.components/SettingsPanel.test.mjs: General still offers theme selection and language selection.node --experimental-strip-types --test components/AppShell.mobile-toolbar.test.mjs components/SettingsPanel.test.mjspasses.问题
聊天顶栏在会话操作旁边放了皮肤和语言两个按钮。这两项在「设置 → 常规」里已经有了（外观：浅色 / 深色 / 跟随系统；语言列表）。
多出来的入口会把注意力从用 agent 拽到配置 web UI 上。顶栏本来就短，也占会话操作的位置。
解决方案
去掉顶栏的皮肤切换、语言菜单，以及语言下拉面板。外观和语言只在「设置 → 常规」里改。
窄屏溢出工具条里也不再带这两项。
测试
components/AppShell.mobile-toolbar.test.mjs：顶栏源码不再挂皮肤/语言操作；其余会话操作仍会保持溢出层打开。components/SettingsPanel.test.mjs：常规设置里仍有外观和语言选择。node --experimental-strip-types --test components/AppShell.mobile-toolbar.test.mjs components/SettingsPanel.test.mjs通过。