fix: pre-create GitHub release to avoid electron-builder publish race - #80
Merged
Merged
Conversation
The dmg and zip mac targets publish concurrently; when the release doesn't exist yet, both race to create it and one target's asset upload silently drops (v0.0.3 only got the zip's blockmap uploaded, the dmg never landed, breaking the Homebrew cask download).
afitzgerald
added a commit
that referenced
this pull request
Sep 30, 2026
fix: pre-create GitHub release to avoid electron-builder publish race
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dmgandzipmac targets concurrently; when the release doesn't exist yet, both race to create it and one target's asset upload silently drops.v0.0.3: only the zip's blockmap made it onto the release, the.dmgnever uploaded, so the Homebrew cask install failed with a 404 download.Ensure GitHub release existsstep before the build/publish step, so electron-builder attaches to an already-existing release instead of racing to create it.Test plan
v0.0.4after merge and confirm both the.dmgand.zip(plus blockmaps) land on the GitHub releasebrew install --cask afitzgerald/diffier/diffiersucceeds afterward