fix: package about-dialog icon into built app - #78
Merged
Merged
Conversation
electron-builder's files list only shipped main/** and renderer/**, so build/icon.png (used by the about dialog via ../build/icon.png) was missing from packaged builds and rendered as a broken image.
afitzgerald
added a commit
that referenced
this pull request
Sep 30, 2026
fix: package about-dialog icon into built app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderer/index.html,../build/icon.png) rendered fine in dev but was never included in packaged builds — electron-builder'sfileslist only shippedmain/**andrenderer/**.build/icon.pngtofilesso the packaged app actually contains it.Test plan
yarn dista build and open the About dialog — icon should render instead of a broken image.