docs: close DX-3 — completion record + publish-propagation operational note#32
Merged
Conversation
…e in release.yml Marks DX-3 complete in the RFC's implementation status and preserves the accepted final milestone record (published artifacts, the 0.4.0 defect and its guard, trusted-publisher status, invariants held). The release workflow gains the operational note from the v0.4.1 incident: a successful trusted publish can appear to fail on read-after-write lag — verify version/attestations before retrying, never retry on the lookup failure alone. Co-Authored-By: Claude Fable 5 <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates DX-series documentation to mark DX-3 as complete, preserve an owner-accepted completion record, and add a release-engineering operational note about npm registry read-after-write propagation to the release workflow comments.
Changes:
- Mark DX-3 “Bootstrap parity” as complete in the DX adoption review status table.
- Add a DX-3 completion record section (closed 2026-07-23) documenting published artifacts, verification outcomes, and operational learnings.
- Add an operational note to
.github/workflows/release.ymlcomments describing trusted publish propagation behavior and retry guidance.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rfc/dx-adoption-review.md | Marks DX-3 complete and adds the preserved DX-3 completion record to the RFC status/record. |
| .github/workflows/release.yml | Adds an operational comment documenting a trusted-publish propagation incident and retry guidance. |
Comments suppressed due to low confidence (1)
rfc/dx-adoption-review.md:290
- This completion record sentence reads like a past-tense fact, but it describes a future action ("exercised by its next legitimate versioned release"). Reword to future tense to avoid implying the exercise has already happened as of the close date.
- **Trusted-publisher status:** dspack-spec — exercised and proven
(provenance on 0.4.1). dspack-export — registered and audited;
exercised by its next legitimate versioned release, recorded in its
CHANGELOG.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | DX-1 · Truth & wayfinding | ✅ Complete — D1–D7 resolved (D4 via compatibility-aware rename); breadcrumb + charter in every public README; studio backlinked; ds-mcp docs single-sourced; owner decision recorded: **aesthetic-function is paused**. All links and quick-starts executed from clean environments. | | ||
| | DX-2 · The adoption guide | ✅ Complete — [`ADOPTING.md`](../ADOPTING.md) (12 steps, each labeled automated / human review / design decision) and [dspack-emit `docs/PROFILES.md`](https://github.com/aestheticfunction/dspack-emit/blob/main/docs/PROFILES.md); verified by executing the guide end to end from clean checkouts, with the walkthrough's clarifications folded back before completion. | | ||
| | DX-3 · Bootstrap parity | ▶ Next — **design first, then code**, per this RFC's DX-3 definition. | | ||
| | DX-3 · Bootstrap parity | ✅ Complete — design accepted ([dx3-bootstrap-design.md](./dx3-bootstrap-design.md)), implemented, published, and verified. See the completion record below. | |
Comment on lines
+19
to
+25
| # Operational note (v0.4.1 incident): a successful trusted publish may | ||
| # temporarily APPEAR to fail because of registry read-after-write | ||
| # propagation — the publish lands but the CLI's post-publish lookup 404s. | ||
| # Before retrying an apparently failed publication, check the package | ||
| # version, dist.attestations, and registry availability directly. Do not | ||
| # retry solely on a post-publish metadata lookup failure: a second run | ||
| # may hit an immutable-version conflict ("cannot publish over"). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marks DX-3 ✅ in the RFC implementation status, preserves the accepted completion record as the final milestone record, and adds the owner-directed operational note (registry read-after-write propagation; verify
dist.attestationsbefore retrying an apparently failed publish) torelease.yml. Docs only.🤖 Generated with Claude Code