Adds support for overriding vfuncs to InteropGenerator. - #1943
Open
universalconquistador wants to merge 1 commit into
Open
Adds support for overriding vfuncs to InteropGenerator.#1943universalconquistador wants to merge 1 commit into
universalconquistador wants to merge 1 commit into
Conversation
This will be very nice for overriding a ResourceHandle's GetData() to return a specific struct, for example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tells InteropGenerator to skip adding vfuncs when there is already a vfunc with the same index further up the inheritance hierarchy.
Pros:
This will be very nice for overriding a ResourceHandle's GetData() to return a specific struct, for example.
This makes IDA decompilation of GetData() calls much nicer, as many of them are represented inline with no variable to change to the concrete type.
Cons:
This does not do any verification that the overriding of a vfunc is compatible signature-wise (return type covariant and parameters contravariant and matching parameter count). And because overriding is driven by vfunc index, this also does not enforce the names match. (Although this actually is a benefit, because we can keep the base vfunc in C# with
[Obsolete]for backwards compat, and then add the new version of the vfunc with a more specific name)