Add cloud optical depth product - #137
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Generated metadata has a dangling ancillary-variable reference, invalid parameters are accepted, and shared plotting behavior lacks coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a cloud optical-depth product derived from liquid and ice extinction, with CLI, plotting, metadata, documentation, and tests.
Changes:
- Implements extinction, optical-depth, uncertainty, and retrieval-status calculations.
- Exposes generation through the API and CLI.
- Adds plotting metadata and logarithmic 1-D plotting support.
File summaries
| File | Description |
|---|---|
cloudnetpy/products/optical_depth.py |
Implements the new product. |
cloudnetpy/products/__init__.py |
Exports the generator. |
cloudnetpy/plotting/plotting.py |
Adds logarithmic 1-D plotting. |
cloudnetpy/plotting/plot_meta.py |
Defines product plotting metadata. |
cloudnetpy/output.py |
Adds product identifiers and references. |
cloudnetpy/cli.py |
Supports hyphenated generator names. |
docs/source/api.rst |
Documents the public generator. |
tests/unit/test_optical_depth.py |
Tests product calculations and output. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 5
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+907
to
+908
| if self._is_log: | ||
| self._mask_non_positive() |
tukiains
force-pushed
the
optical-depth
branch
from
September 10, 2026 09:22
9199643 to
f91939b
Compare
siiptuo
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.