fix(desktop): stage the server with pnpm 12's non-legacy deploy - #100
Merged
Merged
Conversation
Under pnpm 12, `pnpm deploy --legacy` with the hoisted linker prints the install plan but leaves node_modules incomplete, so desktop staging lost better-sqlite3 and every packaging job failed. Use the shared-lockfile deploy (`inject-workspace-packages=true`), which copies workspace packages and their transitive dependencies into the staged server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix desktop packaging after the pnpm 12 upgrade.
pnpm deploy --legacywith the hoisted linker prints the install plan under pnpm 12 but leavesnode_modulesincomplete, so desktop server staging lostbetter-sqlite3. This brokemainCI (@covel/desktop#build) and both Electron jobs of thev0.0.44Build Desktop run. The staging step now uses the shared-lockfile deploy (--config.inject-workspace-packages=true), which copies workspace packages and their transitive dependencies.Type of change
Verification
node_modules; the non-legacy deploy stages 52 packages including@covel/storeandbetter-sqlite3with all eight Node-API prebuilds, with only.bincommand links.pnpm --filter @covel/desktop buildpasses locally: server runtime verification and both staging boot smoke checks.workflow_dispatch,publish_release=false) on this branch — see the linked run.Related issue / context
v0.0.44tag has been deleted (nothing was published) and will be re-created onmainafter this merges.