[dictionary] Fix "Visit" and "Cohort" filters in non-English#10995
Open
driusan wants to merge 2 commits into
Open
[dictionary] Fix "Visit" and "Cohort" filters in non-English#10995driusan wants to merge 2 commits into
driusan wants to merge 2 commits into
Conversation
This fixes the "Visit" and "Cohort" filters in the non-English user languages. The filters were being translated but the data was not, so this translates the table values. Also do not sort "Visit" in the filter so that they show up in the correct order in Japanese.
driusan
added
Module: dictionary
github-actions
Bot
added
Language: PHP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the "Visit" and "Cohort" filters in the non-English user languages.
The filters were being translated but the data was not, so this translates the table values.
Also do not sort "Visit" in the filter so that they show up in the correct order in Japanese.