[dataquery] Dedup recent queries by content so "No run time" eliminates duplicates#10980
Open
HenriRabalais wants to merge 2 commits into
Open
[dataquery] Dedup recent queries by content so "No run time" eliminates duplicates#10980HenriRabalais wants to merge 2 commits into
HenriRabalais wants to merge 2 commits into
Conversation
Collaborator
Author
|
@CamilleBeau PR has ben made for #10600 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "No run times (eliminate duplicates)" filter in the Recent Queries list was deduping on QueryID, but that doesn't actually catch duplicates. Identical queries can get saved under different QueryIDs, since the server dedupes saved queries by an exact string match on the query JSON, so any non-semantic difference (columns added in a different order, an optional visits key) ends up as a distinct QueryID. Keying on QueryID just leaves the duplicates in the list.
Changes
Testing Instructions
Related Issues
Resolves #10600