fix(graphql): generate valid GraphQL for empty enums - #273
Open
Garv978 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Garv978 <[email protected]>
mttrbrts
reviewed
Aug 27, 2026
| case 'Double': | ||
| return 'Float'; | ||
| case 'Concept': | ||
| return 'JSON'; |
Member
There was a problem hiding this comment.
Can you explain this change? Concept should generated as the named types. This function is typically used just for scalar / primitive types.
Contributor
|
Please remove unused var and trailing spaces @Garv978 Always use |
Author
|
its festival time so i am busy give me a day or two please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #248.
Generated GraphQL SDL could be invalid when processing Concerto models.
Changes
Conceptto the GraphQLJSONscalar.buildSchema.Verification
npm testnpx mocha test/codegen/codegen.jsnpx mocha test/verificationgraphql.parse()validationgraphql.buildSchema()validation forhr_base.cto+hr.ctoAll relevant GraphQL tests pass.