Repository navigation
test(desktop): fechar a janela principal escolhe a janela pela URL, não pelo título - #115
Merged
Merged
Conversation
…ão pelo título Enquanto carrega o index.html, a janela destacada também se chama MultTerm e vinha primeiro na lista: o teste fechava a destacada, a aba voltava à principal e o app não encerrava.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que mudou
test-ui/detach.spec.ts› "fechar a janela principal encerra o app": a janela principal passa a ser escolhida pela URL (a destacada abre com?detached=1), não pelo título, e o teste espera a aba chegar na janela destacada antes de fechar a principal.index.html, a<title>MultTerm</title>sobrescreve o título da janela destacada até a aba ser adotada. Nesse intervalo as duas janelas se chamam "MultTerm" e a destacada vem primeiro emgetAllWindows(); o teste fechava a destacada, a aba voltava à principal e o app não encerrava (o timeout de 30 s visto no CI). Num runner lento o intervalo é mais fácil de pegar.Testes
PowerShell — MultTerm | MultTerm→MultTerm | MultTerm→PowerShell — MultTerm | MultTerm, sempre com a destacada primeirotest-ui/detach.spec.tscom a correção, 10 repetições: 30/30npm run typecheck: oknpm test: 166/166 passaramnpm run test:ui: 90/90 passaramCloses #98