Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/architecture/FixedPointNumber.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ export class FixedPointNumber implements IFixedPointNumber {
eq(value: FixedPointNumberValue): boolean {
if (value instanceof FixedPointNumber) {
if (this.scale > value.scale) {
return this.value === value.value * BigInt(10) * (this.scale - value.scale);
return this.value === value.value * BigInt(10) ** (this.scale - value.scale);
}
return this.value * BigInt(10) ** (value.scale - this.scale) === value.value;
}
Expand Down
35 changes: 35 additions & 0 deletions src/architecture/__tests__/FixedPointNumber.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import { FixedPointNumber } from '../FixedPointNumber';

describe('FixedPointNumber.eq', () => {
it('returns true for equal values with the same scale', () => {
expect(new FixedPointNumber(500, 2).eq(new FixedPointNumber(500, 2))).toBe(true);
});

it('returns true for equal values when this.scale > value.scale', () => {
expect(new FixedPointNumber(500, 2).eq(new FixedPointNumber(5, 0))).toBe(true);
});

it('returns true for equal values when this.scale < value.scale', () => {
expect(new FixedPointNumber(5, 0).eq(new FixedPointNumber(500, 2))).toBe(true);
});

it('returns false for different values when this.scale > value.scale', () => {
expect(new FixedPointNumber(501, 2).eq(new FixedPointNumber(5, 0))).toBe(false);
});

it('returns false for different values when this.scale < value.scale', () => {
expect(new FixedPointNumber(5, 0).eq(new FixedPointNumber(501, 2))).toBe(false);
});

it('stays consistent with lt/gt for the same scale-mismatched pair', () => {
const a = new FixedPointNumber(500, 2);
const b = new FixedPointNumber(5, 0);
expect(a.eq(b)).toBe(true);
expect(a.lt(b)).toBe(false);
expect(a.gt(b)).toBe(false);
});

it('handles a larger scale delta correctly', () => {
expect(new FixedPointNumber(5000000, 6).eq(new FixedPointNumber(5, 0))).toBe(true);
});
});