Repository navigation
fix(docker): declare unstract-network in dev essentials compose - #2373
Tyagiquamar wants to merge 1 commit into
Conversation
Standalone docker-compose-dev-essentials.yaml now names the default network unstract-network so Traefik and services match the full stack compose file. Fixes Zipstack#2261
|
 [Low impact] The change is limited to the local development stack’s network setup. The PR appears safe to merge, with a non-blocking gap in when CI runs the new regression tests.
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| def test_dev_essentials_compose_declares_unstract_network(): | ||
| doc = yaml.safe_load(ESSENTIALS_COMPOSE.read_text()) | ||
| networks = doc.get("networks") or {} | ||
| default = networks.get("default") or {} | ||
| assert default.get("name") == EXPECTED_NETWORK |
There was a problem hiding this comment.
These tests will not run on future PRs that change only docker/docker-compose-dev-essentials.yaml. CI excludes docker/** from the unit job, and the e2e job does not run unit-workers, where these tests are collected. Add a CI path that runs these checks when the guarded Compose file changes, so a network-name regression cannot bypass them.
Prompt To Fix With AI
This is a comment left during a code review.
Path: workers/tests/test_dev_essentials_compose_network.py
Line: 16-20
Comment:
**Docker-only PRs skip these checks**
These tests will not run on future PRs that change only `docker/docker-compose-dev-essentials.yaml`. CI excludes `docker/**` from the unit job, and the e2e job does not run `unit-workers`, where these tests are collected. Add a CI path that runs these checks when the guarded Compose file changes, so a network-name regression cannot bypass them.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
What