Repository navigation
Conversation
The `ui` Playwright group has reported 1 error and 0 tests on every CI run since it was added in #2212: CI has npx but never installs tests/e2e/ui, so `npx --no-install playwright test` aborts. groups.yaml documents that a missing install must skip this optional group, but the rig only skipped when npx itself was absent. Optional vitest/playwright groups now skip (exit 5) when their workdir has no node_modules. Required groups such as `frontend` still run and fail, so a dropped install step stays red. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
Contributor
[Medium impact] The PR appears safe to merge.
|
Contributor
Unstract test resultsPer-group results
Critical paths
|
Contributor
Author
|
Parking this. Reviewers are split on skipping the v0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
vitest/playwrightrig groups skip (exit 5, "nothing collected") when their workdir has nonode_modules.npx --no-installand fail when their install step is missing.Why
uie2e group reports 1 error and 0 tests on everyci-testrun, main included. CI never installstests/e2e/ui, sonpx --no-install playwright testaborts withnpx canceled due to missing packages ... ["playwright@..."]. The first main run after [P0-P4] Remove Ant Design from the OSS frontend (shadcn/ui + Midnight Bloom) #2212 merged (run 33623862758, 2026-09-02) already shows it.tests/groups.yamlsays the group isoptionalso that "no browsers installed (or no node_modules) must skip, not gate merges", but the rig only skipped whennpxitself was absent.How
_node_commandintests/rig/cli.pyreturns the existing exit-5 skip for an optional group whoseworkdir/node_modulesis not a directory. This is the same convention the rig already uses whennpxis missing.uisuite stays in the repo for local runs: installtests/e2e/uiand it runs as before.Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
node_moduleschange, from a red error row to a skip. Today that is onlyui. The requiredfrontendvitest group is excluded by theoptionalcheck, and CI installs its dependencies (UN-4183 [MISC] Run frontend typecheck and tests in CI and make the frontend test group required #2302), so it runs exactly as before. Exit 5 already counts as non-failing for optional groups only.Database Migrations
Env Config
Relevant Docs
tests/groups.yamlcomment on theuigroupRelated Issues or PRs
uigroupfrontendvitest groupui-v1groupDependencies Versions
Notes on Testing
tests/rig/tests/test_cli.py: optional group withoutnode_modulesskips; required group withoutnode_modulesstill runs; optional group withnode_modulesruns.optionalguard deleted, the required-group test and both existing command-shape tests fail.ci-testrun is the end-to-end check: theuigroup should show as skipped, not as an error.Screenshots
Checklist
I have read and understood the Contribution Guidelines.
🤖 Generated with Claude Code