Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/background.ts
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ class LLMInvokeHandler {
userPrompt: payload.userPrompt,
responseFormat: payload.responseFormat === 'text' ? 'text' : 'json',
maxTokens: typeof payload.maxTokens === 'number' ? payload.maxTokens : 1024,
temperature: typeof payload.temperature === 'number' ? payload.temperature : 0,
},
storedSettings
);
Expand Down
1 change: 0 additions & 1 deletion src/services/ai.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ export class AIService {
userPrompt,
responseFormat,
maxTokens,
temperature: 0,
};

const response = (await chrome.runtime.sendMessage({
Expand Down
81 changes: 81 additions & 0 deletions src/services/llm/providers.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
import { describe, expect, it, vi } from 'vitest';

const anthropicCreate = vi.hoisted(() => vi.fn());

vi.mock('@anthropic-ai/sdk', () => ({
default: class Anthropic {
messages = { create: anthropicCreate };
},
}));

import { buildOpenAICompatibleRequest, LLMGateway } from './providers';
import type { LLMInvokePayload } from './types';

const payload: LLMInvokePayload = {
systemPrompt: 'system prompt',
userPrompt: 'user prompt',
responseFormat: 'text',
maxTokens: 512,
};

describe('buildOpenAICompatibleRequest', () => {
it.each(['gpt-5.6-luna', 'gpt-4.1', 'kimi-k2'])('omits optional parameters for %s', (model) => {
expect(buildOpenAICompatibleRequest(payload, model)).toEqual({
model,
messages: [
{ role: 'system', content: 'system prompt' },
{ role: 'user', content: 'user prompt' },
],
});
});

it('omits temperature from Anthropic Messages requests', async () => {
anthropicCreate.mockResolvedValue({
id: 'message-1',
content: [{ type: 'text', text: 'response' }],
});

await LLMGateway.invoke(payload, {
provider: 'anthropic',
baseUrl: 'https://api.anthropic.com',
apiKey: 'test-key',
model: 'claude-opus-4-6',
});

expect(anthropicCreate).toHaveBeenCalledWith({
model: 'claude-opus-4-6',
max_tokens: 512,
system: 'system prompt',
messages: [{ role: 'user', content: 'user prompt' }],
});
});

it('omits temperature from native custom fetch requests', async () => {
const fetchMock = vi.fn().mockResolvedValue({
ok: true,
json: async () => ({ message: { content: 'response' } }),
});
vi.stubGlobal('fetch', fetchMock);

try {
await LLMGateway.invoke(payload, {
provider: 'custom_fetch',
baseUrl: 'http://localhost:11434',
apiKey: '',
model: 'local-model',
});
} finally {
vi.unstubAllGlobals();
}

const [, options] = fetchMock.mock.calls[0];
expect(JSON.parse(options.body)).toEqual({
model: 'local-model',
messages: [
{ role: 'system', content: 'system prompt' },
{ role: 'user', content: 'user prompt' },
],
stream: false,
});
});
});
17 changes: 1 addition & 16 deletions src/services/llm/providers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,32 +12,19 @@ import {
type OpenAICompatibleRequest = {
model: string;
messages: Array<{ role: 'system' | 'user'; content: string }>;
max_tokens: number;
temperature?: number;
};

export function buildOpenAICompatibleRequest(
payload: LLMInvokePayload,
model: string
): OpenAICompatibleRequest {
const request: OpenAICompatibleRequest = {
return {
model,
messages: [
{ role: 'system', content: payload.systemPrompt },
{ role: 'user', content: payload.userPrompt },
],
max_tokens: payload.maxTokens,
};

if (!usesLockedKimiTemperature(model)) {
request.temperature = payload.temperature;
}

return request;
}

function usesLockedKimiTemperature(model: string): boolean {
return model.trim().toLowerCase().includes('kimi');
}

export class LLMGateway {
Expand Down Expand Up @@ -112,7 +99,6 @@ export class LLMGateway {
const message = await client.messages.create({
model: settings.model,
max_tokens: payload.maxTokens,
temperature: payload.temperature,
system: payload.systemPrompt,
messages: [
{
Expand Down Expand Up @@ -170,7 +156,6 @@ export class LLMGateway {
{ role: 'system', content: payload.systemPrompt },
{ role: 'user', content: payload.userPrompt },
],
temperature: payload.temperature,
stream: false,
}
),
Expand Down
1 change: 0 additions & 1 deletion src/services/llm/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ export interface LLMInvokePayload {
userPrompt: string;
responseFormat: LLMResponseFormat;
maxTokens: number;
temperature: number;
}

export interface LLMInvokeResult {
Expand Down
Loading