Conversation
cryptography EllipticCurvePublicNumbers requires builtin int; on FreeBSD with gmpy2 installed, ecdsa Point.x()/y() return mpz. Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FreeBSD (and any host with
gmpy2installed) can makeecdsareturngmpy2.mpzfromPoint.x()/Point.y().cryptography.hazmat.primitives.asymmetric.ec.EllipticCurvePublicNumbersrequires builtinint, so TPAP handshake fails with:Cast coordinates to
intin_xy_to_uncompressedbefore building the public key.Verified against a KP125M(US) (
encrypt_type=TPAP) on FreeBSD 14:discover_single+update()succeed after this change.Test plan
gmpy2(or FreeBSD py311-ecdsa using mpz): connect to a TPAP device andawait device.update()