Repository navigation
fix: report package diagnostics and skip DerivedData catalogs - #12
Merged
Merged
Conversation
- run_xcodebuild.sh: match `Package.swift:PACKAGE-TARGET:<name>: error:` diagnostics, which the old pattern missed, so a failed build showed only the exit code. - run_xcodebuild.sh: pass -skipMacroValidation, so packages with Swift macros build on the command line. - xcstrings scripts: exclude `.DerivedData`, where the template builds. The old list had only `DerivedData`, so checked-out package catalogs were scanned. - Add regression tests for the error pattern and the catalog scan.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three gaps found while building the first feature on a project generated from this template, after it added a package with Swift macros (SQLiteData).
Changes
/path/Package.swift:PACKAGE-TARGET:<name>: error: .... The error pattern inrun_xcodebuild.shexpectedfile:line:and missed them, so a failed build printed onlyexit 65. The pattern now accepts any colon-separated location beforeerror:. It still ignoreserror:in the middle of system log lines.run_xcodebuild.shnow passes-skipMacroValidation. AGENTS.md says to select Trust & Enable in Xcode once.DerivedData, but the template builds into.DerivedData. As a result,strip-xcstringscrashed on a read-only GRDB demo catalog, andvalidate-xcstringsreported 24 issues from it.Verification
Scripts/Tests/test_run_xcodebuild.py, plus a.DerivedDatacase in both xcstrings test files. They fail onmain(1 and 2 failures) and pass with this change.mise test-tooling,mise build, andmise validate-xcstringspass.