Skip to content

fix: report package diagnostics and skip DerivedData catalogs - #12

Merged
Zach677 merged 1 commit into
mainfrom
fix/build-script-gaps
Oct 10, 2026
Merged

Zach677 merged 1 commit into
mainfrom
fix/build-script-gaps

Conversation

@Zach677

@Zach677 Zach677 commented Oct 10, 2026

Copy link
Copy Markdown
Owner

Three gaps found while building the first feature on a project generated from this template, after it added a package with Swift macros (SQLiteData).

Changes

  • Package diagnostics were hidden. Xcode reports macro trust errors as /path/Package.swift:PACKAGE-TARGET:<name>: error: .... The error pattern in run_xcodebuild.sh expected file:line: and missed them, so a failed build printed only exit 65. The pattern now accepts any colon-separated location before error:. It still ignores error: in the middle of system log lines.
  • Macro packages failed on the command line. run_xcodebuild.sh now passes -skipMacroValidation. AGENTS.md says to select Trust & Enable in Xcode once.
  • xcstrings scripts scanned package checkouts. The exclude list had DerivedData, but the template builds into .DerivedData. As a result, strip-xcstrings crashed on a read-only GRDB demo catalog, and validate-xcstrings reported 24 issues from it.

Verification

  • New tests: Scripts/Tests/test_run_xcodebuild.py, plus a .DerivedData case in both xcstrings test files. They fail on main (1 and 2 failures) and pass with this change.
  • mise test-tooling, mise build, and mise validate-xcstrings pass.

- run_xcodebuild.sh: match `Package.swift:PACKAGE-TARGET:<name>: error:`
  diagnostics, which the old pattern missed, so a failed build showed only
  the exit code.
- run_xcodebuild.sh: pass -skipMacroValidation, so packages with Swift
  macros build on the command line.
- xcstrings scripts: exclude `.DerivedData`, where the template builds.
  The old list had only `DerivedData`, so checked-out package catalogs
  were scanned.
- Add regression tests for the error pattern and the catalog scan.
@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7468aa80-e5e5-4464-b4d1-5a0685ed5ce9

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T04:40:03.065529Z da3ba8f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Zach677
Zach677 merged commit c3b39dc into main Oct 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant