Repository navigation
Conversation
The test host writes system logs into the xcodebuild log. On current macOS, these logs contain "error:" mid-line, so passing test runs failed.
Modern.UIKit now only creates new apps. The adoption analyzer was most of the repository code and did not serve that goal.
- Use the fixed internal name App for the project, target, scheme, and workspace. The app identity lives in Configuration/Base.xcconfig. - Target iOS 26 and iPhone only. Remove Mac Catalyst. - Enable MainActor default isolation and approachable concurrency. - Add the Packages/Core local package for UI-free logic. - Run hosted tests on the newest iPhone simulator. - Enable GENERATE_INFOPLIST_FILE so INFOPLIST_KEY_* settings apply. Before this change, the app had no launch screen key. - Remove AppPreferences, which had no real consumer. - Remove duplicate mise tasks.
The project keeps the fixed name App, so the creator no longer renames files or edits the Xcode project. It sets three xcconfig values, removes template-only files, and writes a README. CI now runs on macos-26.
AGENTS.md is copied into every generated app, so it now describes the app only. Template maintenance notes move to HACKING.md.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcd0e7baf5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| let package = Package( | ||
| name: "Core", | ||
| platforms: [.iOS(.v26), .macOS(.v26)], |
There was a problem hiding this comment.
Lower the Core package's macOS deployment floor
On Macs running macOS 15.6–15.x, which are supported hosts for Xcode 26, mise test-core builds the test bundle with a macOS 26 minimum deployment target and therefore cannot execute it. SwiftPM defines entries in platforms as minimum deployment versions, while Xcode 26 supports macOS 15.6 or later, so the package should use a compatible macOS floor rather than mirroring the app's iOS version.
AGENTS.md reference: AGENTS.md:L58-L59
Useful? React with 👍 / 👎.
| description = "Alias for run-ios" | ||
| run = [{ task = "run-ios" }] | ||
| SIMULATOR_ID="${SIMULATOR_ID:-$(./Resources/DevKit/scripts/simulator_udid.py)}" | ||
| APP_PATH=".DerivedData/Build/Products/${CONFIGURATION:-Debug}-iphonesimulator/App.app" |
There was a problem hiding this comment.
Honor DERIVED_DATA when locating the simulator app
When mise run-ios -- DERIVED_DATA=/some/path is used, the nested build writes its products under that override because run_xcodebuild.sh honors DERIVED_DATA, but this hard-coded path still reads from .DerivedData; the subsequent PlistBuddy/install steps therefore fail even though the build succeeded. Derive APP_PATH from ${DERIVED_DATA:-$PWD/.DerivedData} as the previous task did.
AGENTS.md reference: AGENTS.md:L64-L65
Useful? React with 👍 / 👎.
- Default to iPhone and iPad. TARGETED_DEVICE_FAMILY and SUPPORTS_MACCATALYST now live in Base.xcconfig instead of the Xcode project. - Add mise build-catalyst. mise build also runs it when Catalyst is on. - Name the workspace after the project. Scripts find the single root .xcworkspace, and the creator renames it to the repository name. - Add --iphone-only and --mac-catalyst to the creator.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f9b125f66
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # execution policy SIGKILLs a fully unsigned Catalyst test host on its first | ||
| # launch after a clean build, which breaks `mise clean && mise test` and CI. | ||
| description = "Run Core package tests and hosted app tests" | ||
| run = [{ task = "test-core" }, { task = "test-app" }] |
There was a problem hiding this comment.
Forward aggregate test overrides to test-app
When a caller uses the documented mise test -- SIMULATOR_ID=<udid> form, this aggregate task discards the trailing argument because its child-task entries specify no args; testing the task showed test-app still selecting its automatic simulator ID. Forward the supplied arguments to test-app so configuration overrides work through the full test entry point.
AGENTS.md reference: AGENTS.md:L66-L67
Useful? React with 👍 / 👎.
| print(f"Bundle identifier: {bundle_id}") | ||
| print(f"Development team: {development_team or '(not set)'}") | ||
| repo_name = args.repo.split("/")[-1] | ||
| parent_dir = Path(args.parent_dir).expanduser().resolve() |
There was a problem hiding this comment.
Create the requested parent directory before cloning
When --parent-dir names a directory that does not already exist, subprocess.run fails while trying to use it as cwd, so project creation never reaches gh. The previous implementation created this directory recursively, and the option does not state that callers must pre-create it; create parent_dir before invoking the clone command.
Useful? React with 👍 / 👎.
Generated apps do not have skills/, so the copied CI workflow and the test-tooling task failed on the first run. Generated apps now start without .github and without test-tooling.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 148a091d98
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| configure( | ||
| repo_root, | ||
| workspace_name=repo_name, | ||
| display_name=args.display_name or repo_name, |
There was a problem hiding this comment.
Reject whitespace-only display names
When a caller supplies a value such as --display-name ' ', this expression treats it as truthy instead of using the repository name or rejecting it; set_xcconfig_value then applies rstrip() and writes APP_DISPLAY_NAME = with no value. The generated app therefore has an empty CFBundleDisplayName, and the default build verification does not detect the malformed identity. Strip and validate the argument before this fallback.
AGENTS.md reference: AGENTS.md:L8-L9
Useful? React with 👍 / 👎.
- validate_xcstrings: reduce Swift interpolations and format specifiers to the same placeholder before comparing source keys with catalog keys. Before, "Good for \(days) days" was reported as orphaned and missing. - validate_xcstrings: check each plural and device variation. - strip_stale_xcstrings: do not add a source stringUnit to entries that use variations. - Run the DevKit script tests in test-tooling. They stay in the template.
- Replace LaunchScreen.storyboard with the generated UILaunchScreen key. - Replace main.swift with @main on AppDelegate. - Configure the scene delegate only in Info.plist. Remove the duplicate AppDelegate scene configuration and the @objc class names. - Generate CFBundleDisplayName and the standard keys. Info.plist now holds only the scene manifest. - Remove window.tintColor so the AccentColor asset applies. - Enable SWIFT_UPCOMING_FEATURE_MEMBER_IMPORT_VISIBILITY.
The old generated file ignored any folder named Dependencies or build, so App/Dependencies/ could never be committed.
- run_xcodebuild.sh owns the shared xcodebuild arguments and streams the output live. It no longer replaces HOME, which hid the user's Git configuration from package resolution. - Rewrite scan.license.sh (zsh) in Python. The old script used echo -e on license text, which changed backslash sequences. - Pin SwiftFormat and xcbeautify in mise [tools]. Add .swiftformat. - Remove Prettier and the Node.js dependency. - Use environment variables for overrides instead of -- KEY=value. - Remove tidy_workspace_schemes.py and the nushell review-branch command.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7226dc6b56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| viewController.loadViewIfNeeded() | ||
|
|
||
| #expect(!viewController.view.subviews.isEmpty) |
There was a problem hiding this comment.
Assert root behavior instead of its subview layout
This assertion passes for any incidental subview without proving that the controller exposes the intended behavior, and it fails if the same content is later implemented through a child controller or custom root view. Replace it with an observable behavior or state assertion rather than inspecting the view hierarchy.
AGENTS.md reference: AGENTS.md:L71-L75
Useful? React with 👍 / 👎.
The repository had a root Resources/ folder for tooling next to App/Resources/ for app files. Scripts now live in Scripts/ with their tests in Scripts/Tests/, and manual licenses in Licenses/. Also leave .gitattributes out of generated apps. Its Linguist rules point at template-only folders.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d922e88e63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| with: | ||
| install: false | ||
| - name: Run tooling unit tests | ||
| run: mise run test-tooling |
There was a problem hiding this comment.
Skip configured tools in the tooling job
In the Ubuntu tooling job, install: false only prevents mise-action from running mise install; mise run still automatically installs every missing tool from mise.toml before starting a task. Consequently, a cold runner downloads SwiftFormat and xcbeautify even though these Python-only checks do not use them, and any installation failure prevents the tests from running. The official mise run documentation identifies --skip-tools (or MISE_TASK_RUN_AUTO_INSTALL=false) as the way to disable this behavior, so apply it to both tooling commands.
Useful? React with 👍 / 👎.
Summary
Fix
mise testfailing on passing runs. The test host writes system logs that containerror:mid-line; the wrapper now matches only compiler and xcodebuild error lines.Remove the existing-repo adoption tooling. The template now only creates new apps.
Use the fixed internal name
Appfor the project, target, and scheme. The workspace takes the repository name, and scripts find the single root.xcworkspace.Configuration/Base.xcconfigowns the app identity and the platform switches. The default is iPhone and iPad; iPhone-only (TARGETED_DEVICE_FAMILY = 1) and Mac Catalyst (SUPPORTS_MACCATALYST = YES) are one-line changes or creator flags.Target iOS 26. Enable
MainActordefault isolation and approachable concurrency.Add
Packages/Corefor UI-free logic, tested withswift teston macOS.Enable
GENERATE_INFOPLIST_FILEfor the app target. Before,INFOPLIST_KEY_*settings did not apply, and the app had no launch screen key.Remove
AppPreferences, which had no real consumer, and duplicate mise tasks.Shrink
create_project.pyto identity, platform, and workspace setup plus pruning of template-only files.Rewrite
AGENTS.mdto describe the generated app only.Fix the xcstrings scripts: interpolated strings (
"\(n) days"vs%lld days) and plural variations no longer fail validation.Align with the Xcode 27 iOS template:
UILaunchScreenkey instead ofLaunchScreen.storyboard,@maininstead ofmain.swift, one scene configuration in Info.plist, nowindow.tintColoroverride, member import visibility on.Trim
.gitignore. The old rules ignored any folder namedDependenciesorbuild.Tooling: the xcodebuild wrapper streams output live and no longer replaces
HOME; the license scanner is Python; SwiftFormat and xcbeautify are pinned in mise[tools]; Prettier, Node.js, nushell, and the scheme tidy script are removed; overrides use environment variables.Move
Resources/DevKit/scriptstoScripts/(tests inScripts/Tests/) andResources/AdditionalLicensestoLicenses/, soResources/exists only insideApp/. Generated apps no longer get the template's.gitattributes.Verification
Local, Xcode 27.0:
mise clean, thenmise build,mise test,mise test-tooling,mise validate-xcstrings,mise format-lint: all pass, no compiler warnings.UIDeviceFamily = [1, 2]and all iPad orientations; iPhone-only builds[1]; with Catalyst on,mise buildalso buildsDebug-maccatalyst/App.app; with Catalyst off,mise build-catalystexits with a clear message.mise run-ios: the app launches full screen on the iPhone 18 Pro simulator.mise testexit 65.Follow-up commits, also local on Xcode 27.0:
mise test-tooling: 12 Python tests pass, including new red-then-green tests for the xcstrings fixes.configure(..., iphone_only=True)builds and passesmise test, with display name趁鲜andUIDeviceFamily = [1].