Skip to content

fix(linux): let the panel open the tray menu #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguodev merged 1 commit into from
Nov 2, 2026
Merged

fix(linux): let the panel open the tray menu #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions lib/service/shared/menu/tray/platform.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'dart:async';

import 'package:onexray/core/tools/logger.dart';
import 'package:onexray/core/tools/platform.dart';
import 'package:onexray/service/shared/menu/tray/entry.dart';
import 'package:tray_manager/tray_manager.dart' as native;
Expand Down Expand Up @@ -36,15 +37,30 @@ final class NativeTrayPlatform implements TrayPlatform {
if (tray == null) throw StateError('Unable to create the tray icon');
_tray = tray;
_onMenuVisibility = onMenuVisibility;
tray.setContextMenuTrigger(native.ContextMenuTrigger.none);
// Linux tray icons are StatusNotifierItems: the panel draws the menu from
// the exported dbusmenu, and nativeapi's openContextMenu() always returns
// false there. With the trigger `none` the item exports /NO_DBUSMENU, so no
// menu ever appears. Let the panel open the menu on any click instead.
final hostShowsMenu = AppPlatform.isLinux;
tray.setContextMenuTrigger(
hostShowsMenu
? native.ContextMenuTrigger.clicked
: native.ContextMenuTrigger.none,
);
tray.iconSize = nativeapi.Size(width: 18, height: 18);
tray.setTooltip('OneXray');
if (AppPlatform.isMacOS) tray.setTitle('');
_listener = tray.addListener((event) {
if (event is native.TrayIconClickedEvent ||
event is native.TrayIconRightClickedEvent) {
onClick();
if (event is! native.TrayIconClickedEvent &&
event is! native.TrayIconRightClickedEvent) {
return;
}
if (hostShowsMenu) {
// Some hosts still call Activate/ContextMenu next to the exported menu.
ygLogger('Tray ${event.runtimeType} ignored: the panel shows the menu');
return;
}
onClick();
});
}

Expand Down