Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit coverage for public spatial-analysis contracts: exact point-feature values, shape measurements and cache behavior, synchronized gene filtering, metadata errors, vector colors, packaged gene sets, KNN/radius RNAflux counts, and plotted coordinates, geometry, labels, and loadings. The existing plotting tests were entirely commented out.
Three strict expected-failure regressions document independently reproduced implementation defects: #195 (RMSE arithmetic), #196 (noninteger span truncation), and #197 (composition comparison with standard boundary names). Implementation and dependency metadata are unchanged.
The PR workflow now runs the existing tests and new
unit_testsfolder, checks at least 90% statement coverage, and installs a compatible scientific dependency set to avoid current dependency/API and serialized-model incompatibilities. All six existing OS/Python install jobs are retained.Validation:
pytest tests unit_tests --cov=bento --cov-fail-under=90passed with 141 passed, 3 expected failures and 90.35% statement coverage (1,825/2,020 statements). Focused contract tests, test-file static checks,git diff --check, and dependency compatibility checks passed. Focused suite: 113 passed, 3 expected failures. GitHub Actions run 40273671541 completed successfully on commit51d0506728db601c06fd759bbc34e1a12e5b42f7, with all six jobs green; the Linux test job independently passed 141 tests / 3 expected failures and the 90% coverage gate.