Skip to content

feat(net10): target .NET 10 and .NET 8 - #4

Merged
jrgcubano merged 23 commits into
masterfrom
feat/net10
Oct 1, 2026
Merged

jrgcubano merged 23 commits into
masterfrom
feat/net10

Conversation

@jrgcubano

@jrgcubano jrgcubano commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Summary

All three packages now target net10.0 and net8.0 on the .NET 10 SDK; netstandard2.0 and net6.0 are dropped. That is breaking for .NET Framework and older .NET apps (they stay on 1.4.x), so the release is 2.0.0. The public API is unchanged: package validation against 1.4.0 passes with only PKV006 (dropped TFMs) suppressed.

  • System.Text.Json package removed (in-box on net8+); Newtonsoft.Json 13.0.4.
  • Tests on xUnit v3 3.2.2 and FluentAssertions 7.2.2.
  • Cake 6, still driven by config.yml; MinVerMinimumMajorMinor 2.0 so master previews are 2.0.0-preview.
  • Solution migrated to src/Appy.Spatial.GeoJSON.slnx.
  • Workflows on actions/checkout@v6, actions/cache@v5, actions/setup-dotnet@v5 with the SDK from global.json.

Plan: docs/plans/001-net10-migration.md

Verification

  • dotnet cake (Default target) green locally on SDK 10, warnings as errors, 6/6 tests.
  • Nuspecs: TextJson has no System.Text.Json dependency; Newtonsoft depends on Newtonsoft.Json >= 13.0.4; groups only for net8.0 and net10.0.
  • Package validation passes with only PKV006 suppressed.
  • PR CI green on all three OS jobs.

Merging publishes a 2.0.0-preview.0.N build (publish.yaml on master); tagging 2.0.0 publishes the release.

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings September 30, 2026 13:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI balanced review requested due to automatic review settings September 30, 2026 14:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI balanced review requested due to automatic review settings September 30, 2026 14:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI balanced review requested due to automatic review settings September 30, 2026 16:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI balanced review requested due to automatic review settings September 30, 2026 16:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The supported .NET 8 assets are not runtime-tested, and the dependency cache key does not track the updated manifests.

Review effort: Balanced
Findings: 2 Medium severity · 1 Low severity

Open (3)

Comment thread dotnet-tools.json Outdated
Comment thread src/Appy.Spatial.GeoJSON.Tests/Appy.Spatial.GeoJSON.Tests.csproj Outdated
Comment thread docs/plans/001-net10-migration.md Outdated
Copilot AI balanced review requested due to automatic review settings October 1, 2026 09:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The global NU1507 suppression removes an important package-source provenance safeguard.

Review effort: Balanced
Findings: 2 Medium severity · 1 Low severity

Open (3)
Previously missed (1)

In code that hasn't changed since last review

Medium severity Avoid globally suppressing NU1507; configure package source mapping

src/​Directory.Build.props:31

Suppressing NU1507 globally hides the warning that Central Package Management is restoring from multiple unmapped sources, so dependency provenance varies with each developer or runner configuration. NuGet's guidance is to configure a single source or package source mapping; add that repository configuration and then remove this suppression rather than disabling the safeguard for every project.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The supported .NET 8 runtime is untested, and the package-source safety warning NU1507 is globally suppressed.

Review effort: Balanced
Findings: 3 Medium severity · 1 Low severity

Open (4)

Comment thread src/Directory.Build.props Outdated
Copilot AI balanced review requested due to automatic review settings October 1, 2026 10:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The migration is internally consistent and validated, with only minor stale details in the implementation plan.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
Resolved since last review (4)

Comment thread docs/plans/001-net10-migration.md Outdated
Copilot AI balanced review requested due to automatic review settings October 1, 2026 10:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The migration is internally consistent, package compatibility is explicitly validated, and both supported frameworks are tested.

Review effort: Balanced
Findings: None

Resolved since last review (1)

@jrgcubano
jrgcubano merged commit a7fdaee into master Oct 1, 2026
4 checks passed
@jrgcubano
jrgcubano deleted the feat/net10 branch October 1, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants