Repository navigation
fix(editor): stop flagging straight quotes and resolve every upstream language - #20
Merged
Merged
Conversation
added 2 commits
October 10, 2026 17:14
…d "'" from warningCharacters set, added doc comment explaining straight quotes are correct in code
…age enum from 12 to 34 statics matching upstream TreeSitterLanguage (42 cases); fixed identifier mismatches shell→"bash", plaintext→"plainText", csharp→"cSharp"; split .tsx from .typescript; added Language.allLanguages public static; updated language(for:) and bridge alias; updated test expectation app.tsx→.tsx; MEMORY entry #19 referenced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19
What
Warning characters (UI): removed straight
"and'fromCodeEditorView.warningCharacters. Straight quotes are correct in code — flagging them painted every string literal in every language with a warning background. Smart quotes, NBSP and ZWSP remain flagged.Language coverage (Core):
Languagegrew from 12 to 34 statics, one per grammarCodeEditLanguagesactually ships (42TreeSitterLanguagecases; jsdoc/markdownInline/regex/ocaml/agda/goMod deliberately not exposed). Identifiers now matchTreeSitterLanguage.rawValueexactly —bash,plainText,cSharp— soCodeLanguage.editorLanguage(the reverse map) works..tsxis its own language;.m/.mmbelong to objc only; html +=xml, text +=cfg/conf.Also: public
Language.allLanguagesis now the single ordered list used by bothlanguage(for:)and the UI bridge.Verification
swift build— passes (one pre-existing unused-variable warning inEditorState.swift, unrelated)swift test— 73 tests / 17 suites pass, including the updatedLanguage.fromExtension(app.tsx→.tsx)swift-format lint --recursive --strict— clean