Fix aie_dm_resource propagation in fifo_buffer_stream - #15
Open
AngryLoki wants to merge 1 commit into
Open
Conversation
`Resource` appears in the template parameter list but is never used in the class body. The fix applies `add_memory_bank_t`-style logic, similar to other places in the codebase. Closes Xilinx#14
jbelloncastro
approved these changes
Aug 11, 2026
Contributor
|
Hi there. It seems I am no longer a reviewer but will let the maintainers know about this. The change looks good to me, thanks and well spotted! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resourceappears in the template parameter list but is never used in the class body. The fix appliesadd_memory_bank_t-style logic, similar to other places in the codebase.Closes #14