Repository navigation
Test the surface size wait and its 60-frame give-up - #51
Merged
Merged
Conversation
Xget7
force-pushed
the
android-surface-fallback-test
branch
from
October 20, 2026 22:15
12afbf5 to
3c40b5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The rotation fix's wait-then-give-up decision moves out of
VulkanSurfaceinto a class with no Vulkan or Android types.presentation/ +├── SurfaceSizeWait.h # window size, stale count -> wait / rebuild / giveUp └── VulkanSurface.cpp # asks it, does the Vulkan calls and the loggingBehaviour and log lines are as in #45,
kMaxStaleChecksis still 60.CI compiles and runs the test on the host, in the same
buildjob step pattern asWorldFrameCompletionTest.Evidence
With the class stubbed,
SurfaceSizeWaitTestfails:Assertion failed: (wait.pending(kPortrait)) ... line 19.After: it exits 0.
scripts/lint-cpp.shclean (includes the arm64splatkit_android_testslink); ANDROID-SPIRV hashes equal the baseline; Gradle:splatkit:assembleRelease :app:assembleRelease :splatkit:testDebugUnitTestsucceeds; hostWorldFrameCompletionTestandSurfaceSizeWaitTestexit 0. The new CI step "Check surface size wait on host" runs in thebuildjob.Merge Danger
Door: Two-way.
Blast Radius: Android
A mistake would show as a stuck or wrongly sized swapchain after rotating a phone, which is the check to repeat on the Mi 9.