Repository navigation
Show the SH degree actually drawn in the iOS dev HUD - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The iOS dev HUD "Pipe" row built
SHnfrom the requested settings only, so kitchen_500k.spz (SH degree 0) showedSH1.The renderer holds the world's degree already (
GpuWorldInfo.shDegree); the stats path now carries it up to Swift and Kotlin.var pipelineText: String { - let sh = min(view.shDegree, view.maxShDegree) + let sh = min(view.shDegree, view.maxShDegree, stats.loadedShDegree)The Android dev HUD (
SplatHudView) has no SH row, so it has no equivalent bug and stays as is.Only its public
SplatStatsgains the field, to keep the platforms in step.Evidence
SH1for a degree-0 world on an iPhone 17 Pro.After: the row takes the world's degree into the minimum, so it reads
SH0for that world.No device ran this change.
No iPhone, Android device or emulator.
scripts/lint-cpp.shclean.:splatkit:assembleRelease :app:assembleRelease :splatkit:testDebugUnitTestpassed.The ios-dev Swift files parse (
swiftc -parse) but the app was not built or run.npm run checkandnpm run lintskipped: the React Native package does not mirrorSplatStatsand is unchanged.Merge Danger
Door: Two-way.
SplatStatsgains one field on each platform and the JNI stats array grows from 11 to 12 floats, with Kotlin and C++ changed together.Blast Radius: Stats
SKSplatStatsis a positional C struct and the new field is last, so existing readers are unaffected.The iOS XCFramework mirror and Android AAR republish only on a version bump, which this change does not make.