Skip to content

security(contracts): Sept 2026 report batch — escrow RAM caps, arbitrator conflicts, feed score fixes - #87

Merged
paulgnz merged 1 commit into
mainfrom
security/contract-batch-2026-09
Sep 24, 2026
Merged

paulgnz merged 1 commit into
mainfrom
security/contract-batch-2026-09

Conversation

@paulgnz

@paulgnz paulgnz commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

agentescrow (additive: tables limits/openjobs, actions setlimits/cleanstale)

  • Per-client cap on unfunded jobs (openjobs counter, default 5); freed on fund, cancel, removejob
  • Per-job milestone cap (default 20)
  • cleanstale: permissionless removal of unfunded jobs older than stale_after (default 30 days)
  • A job's client or agent can no longer be its arbitrator (createjob, selectbid, arbitrate);
    arbitrate falls back to the owner for existing conflicted jobs

agentfeed (no ABI change)

  • verifypay(false) now removes the paid review from scoring (context and directional trust
    reversed, aggregate recomputed); recalc excludes it too; a proof is decided only once
  • resolve(upheld) rebuilds the aggregate with recalc's decayed weights instead of
    subtracting the undecayed weight (avg could exceed 100%)

Tests: agentescrow 275 passing (8 new), agentfeed 61 passing (3 new).
ABI diff against mainnet: no existing struct, action or table changed. agentescrow adds setlimits, cleanstale, limits, openjobs; agentfeed ABI unchanged.

Review gating (reviews only from paying clients) is deliberately not in this batch.

…ator conflicts, feed score fixes

agentescrow (additive: tables limits/openjobs, actions setlimits/cleanstale)
- Per-client cap on unfunded jobs (openjobs counter, default 5); freed on fund, cancel, removejob
- Per-job milestone cap (default 20)
- cleanstale: permissionless removal of unfunded jobs older than stale_after (default 30 days)
- A job's client or agent can no longer be its arbitrator (createjob, selectbid, arbitrate);
  arbitrate falls back to the owner for existing conflicted jobs

agentfeed (no ABI change)
- verifypay(false) now removes the paid review from scoring (context and directional trust
  reversed, aggregate recomputed); recalc excludes it too; a proof is decided only once
- resolve(upheld) rebuilds the aggregate with recalc's decayed weights instead of
  subtracting the undecayed weight (avg could exceed 100%)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant