Repository navigation
Solace Fixes - #1633
Open
BlackDog86 wants to merge 2 commits into
Open
Solace Fixes#1633BlackDog86 wants to merge 2 commits into
BlackDog86 wants to merge 2 commits into
Conversation
BlackDog86
force-pushed
the
1631-Solace-Fixes-2
branch
from
October 23, 2026 21:54
81ca8d9 to
d361cf8
Compare
BlackDog86
force-pushed
the
1631-Solace-Fixes-2
branch
4 times, most recently
from
October 24, 2026 14:43
451482e to
75062b7
Compare
… play on mission start Add new condition to prevent creation of redundant gamestates for units which were not modified / cleansed Add event triggers for units which spawned and/or changed team
BlackDog86
force-pushed
the
1631-Solace-Fixes-2
branch
from
October 25, 2026 08:37
75062b7 to
1582487
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #1631
Tentative fix for various solace issues:
Prevent un-necessary gamestate creation on units which were not modified by the ability (code from WhakOMatic)
New buildvis which ensures that the target perk content PFX will play all the time
Event triggers for spawned units and units that changed team so they can be properly affected by the solace aura
Initial testing looks promising - further testing by others would be appreciated.