Repository navigation
1631 solace fixes - #1632
Closed
BlackDog86 wants to merge 18 commits into
Closed
1631 solace fixes#1632BlackDog86 wants to merge 18 commits into
BlackDog86 wants to merge 18 commits into
Conversation
Adds events to `XComGameState_Effect::RemoveEffect()`. ''PrePersistentEffectRemoved'' provides access to the effect and target states before `EffectTemplate.OnEffectRemoved()` is called; `'PostPersistentEffectRemoved'` provides access to the same states right after. Resolves X2CommunityCore#1576
Removes condition that prevents aim modifier from being added to weapon summary for items present in the `EquipmentExcludedFromStatBoosts` config array.
Adds an improved version of `X2Effect_Persistent::FreeKillOnDamage()` that provides additional arguments related to the calculated damage value.
…RK" from the GetPawnFromSaveData Kismet Sequence Action as well as normal SPARKS.
Adds `AddReactionFlatModifier_CH()` that passes the ability state from the hitcalc and `ModifyReactionFireSuccess_CH()` that provides the effect state and the passed ability state.
… code (X2CommunityCore#1625) * Reload the weapon at start of tactical if not handling a tactical<>tactical transfer * Improve BuildNewGameStateFn for 'HotLoadedAmmo' * compilation fix * Check to not override MergeAmmoAsNeeded behavior
Make FreeKill functions apply regardless of the current damage, and bypass sustaining effects.
… were not modified /cleansed Update visualization to ensure perk content PFX always play Remove redundant checks OnUnitChangedTile
BlackDog86
force-pushed
the
1631-Solace-Fixes
branch
from
October 23, 2026 19:00
04d2aa2 to
13a40a2
Compare
Contributor
Author
|
Closing, screwed up the file structure in sourcetree, sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1631
Tentative fix for various solace issues:
Initial testing looks promising - further testing by others would be appreciated.