Force removal of test directories in cleanup

[ekamran]

Fixes #301

cleanup.php removes the preparation directory with rm -r. Without -f, rm stops to ask about write-protected files such as the read-only objects in a nested git checkout, and cleanup waits for input that never arrives. The two commands beside it already use rm -rf, so the missing flag looks like an oversight.

Changes

• cleanup.php: remove the preparation directory with rm -rf, matching its neighbours.
• functions.php: the same flag on the default WPT_RM_TEST_DIR_CMD, which runs over SSH.
• functions.php: that default concatenated WPT_TEST_DIR unescaped, so a path with a space became several targets and a path with a semicolon ran a second command on the remote host. It now goes through escapeshellarg(). Older than this change, but forcing removal makes it worth closing here.
• README.md: both places documenting WPT_RM_TEST_DIR_CMD now show rm -rf, since anyone who set it by hand still has the original problem.

Testing

On a directory containing a read-only file, with a terminal attached:

• rm -r asks override r--r--r--...? and then fails with Directory not empty. The directory survives.
• rm -rf removes it, no prompt.

rm -rf still returns a non-zero exit code on genuine failures, so perform_operations() still reports them. One behaviour changes: removing a path that does not exist now succeeds quietly instead of reporting a failure.

php -l passes on both changed files, and PHPCS shows the same single pre-existing warning as master.

On macOS the prompt reads override ...? rather than the remove write-protected regular file ...? wording in the report.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @marlonanjos.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: marlonanjos.

Co-authored-by: ekamran <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.