Repository navigation
Settle the Ethereum Syndication on the Holder's Balance - #183
Merged
Merged
Conversation
…der's balance The batch operators' housekeeping prunes a released sysio.synd envelope once its approval is acknowledged, so ethereum-settled could find the row gone and wait out its whole budget. The step now waits for the holder's LIQETH principal, which pruning cannot take back, and no longer reads the envelope. ethereum-requested already checks the envelope's amount when it records it.
heifner
marked this pull request as ready for review
November 10, 2026 14:08
huangminghuang
approved these changes
Nov 10, 2026
huangminghuang
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the current diff and surrounding settlement/pruning logic. No actionable findings. Validation: isolated TypeScript compilation passed and all 58 settlement unit tests passed. The live cross-chain flow was not run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ethereum-settledinflow-syndication-plugin-underwritingwaited for thesysio.syndenvelope to show its whole principal released. The batch operators' underwriter housekeeping runs every 10 minutes and prunes a released envelope as soon as its approval is acknowledged. When that pass lands between the approval and the step's first read, the row is gone and the step waits out its 420 s budget. e2e run 42721597511 failed this way: theapprove, the crank that acknowledged it andpruneenvwere pushed in one plugin pass, 16 s before the step's first read.ethereum-requestedalready checks the envelope'ssynd_totalwhen it records it.