Repository navigation
Close the liveness test subscription on failure - #150
Merged
Merged
Conversation
qhool
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finallyblock.Why
The test previously closed its subscription only after the event wait completed successfully. The
finallyblock also closes it if writing the PID fixture, the event wait, or the assertion throws. Existing suite teardown still handles client disconnection.This test-only cleanup is separated from Tools #97 as requested in review. It can be reviewed and merged independently of the operator lifecycle flows.
Validation
LocalFileDebuggingClient.test.ts: all 14 tests passed on the current master-based branch, including process-liveness discovery.