Repository navigation
Drop retired OPP carriers from the harness - #121
Merged
Merged
Conversation
valthon
force-pushed
the
cleanup/retired-opp-carriers
branch
from
October 10, 2026 12:14
3012c02 to
6fb42b7
Compare
valthon
force-pushed
the
fix/sysio-670-consumers
branch
from
October 10, 2026 22:44
f258cc5 to
e3d76da
Compare
wire-sysio PR #674 removes the retired reserve, swap, underwriting, pretoken, staking and processing-error OPP carriers, and the underwriter outpost roles on the sysio.chains registry. The harness still wrote those registry fields, decoded the removed payloads for display, and scanned for SwapRevert. Stop writing operator_registry_addr / source_deposit_addr in RegistrySteps and drop the fixtures that carried OperatorRegistry and ReserveManager addresses for the deleted underwriter daemon. Remove the retired display decoders (StakeUpdate, StakeResult and AttestationProcessingError among them) and the swap-revert scanner; the codec test now pins that removed wire values still render raw beside decoded entries, and the envelope-scan tests use live attestation types. Native sysio.swap tooling, the Solana OperatorRegistry PDA, and the node-owner and pretoken purchase history surfaces stay: they are live. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01ARSeK35wwkiAy4et9mCkVm
The syndication-underwriting flow's later-intake-held step failed in e2e run 38009710729 with "missing decoded syndication". The step polled until the depot held the intake envelope, then read the relayed SyndicateLIQ from the OPP debugging artifacts once. The debugging plugin writes that artifact after the depot accepts the envelope; in that run it landed 85 ms after the read. Read the decoded attestation inside the poll, so the step waits for both the held row and the persisted artifact before it records the epoch and bond request. The custody check against the attestation's own total is unchanged. readDecodedSyndications is exported so the read can be tested on its own. Move the artifact-writing test helpers out of the envelope-scan tests into a shared fixture, and cover the filter, the wait and the custody refusal. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01ARSeK35wwkiAy4et9mCkVm
wire-sysio removes CHALLENGE_REQUEST, CHALLENGE_RESPONSE and their ChallengeRequest / ChallengeOperatorHash payloads: no chain produces them, and the depot dropped both on dispatch. The OPP display decoder was their last consumer here. Remove the two decoders. The codec test now pins that both removed wire values (60932, 60945) render raw beside a decoded entry. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01ARSeK35wwkiAy4et9mCkVm
valthon
force-pushed
the
cleanup/retired-opp-carriers
branch
from
October 10, 2026 23:25
db64dce to
0b57573
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows wire-sysio #674, which removes the retired reserve, swap, underwriting, pretoken, staking, processing-error and challenge OPP carriers and the underwriter outpost roles on the
sysio.chainsregistry. Stacked on #116 (rebased onto its current head, e3d76da).Changes:
RegistrySteps.ts: theregchainplaceholder and bothsetoutpostwrites no longer setoperator_registry_addr/source_deposit_addr; the Solana comment now says why the row is filled that way (sysio.chainsrejects a Solana row that setsopp_inbound_addr).AttestationCodec.ts: remove the retired display decoders (PretokenPurchase, PretokenYield, ReserveBalanceSheet, WireTokenPurchase, SwapRequest, SwapRemit, UnderwriteIntentCommit, SwapRevert, DepositRevert, StakeUpdate, StakeResult, AttestationProcessingError, ChallengeRequest, ChallengeOperatorHash). The codec test now pins that removed raw values (3001, 3002, 3004, 43520, 60928, 60932, 60934, 60945, 60951, 60952, 60955, 60962) render raw beside a decoded entry.oppEnvelopeScan.ts: remove the retiredcontainsSwapRevertscanner; its tests use live attestation types with the same coverage.SyndicationScenario.ts: the intake check waits inside its poll for the decodedSyndicateLIQas well as the held envelope. The debugging plugin writes the relayed artifact after the depot accepts the envelope, so a single read after the poll could run before it existed; that is howlater-intake-heldfailed with "missing decoded syndication" in an earlier e2e run.readDecodedSyndicationsis exported, and the artifact-writing test helpers now live in a shared fixture.OperatorDaemonToolnames only OPP, OPPInbound and BAR).Unchanged on purpose: native
sysio.swaptooling, the SolanaOperatorRegistryPDA,operatorRegistryConfig(it configuressysio.opreg),PretokenPurchaseHistory(live liqsol-core account), and every node-owner registration path.Validation, per commit, in a platform-root worktree linked to sibling sdk-core (wire-libraries-ts #105) and the OPP models each commit pairs with:
pnpm install && pnpm build && pnpm run lint && pnpm testAll 12 flows passed locally on these commits before this rebase (head db64dce, on #116's previous head) with the companion heads (wire-sysio
4291581446; Solana before its rebase); the rebase adds #116's SDK 1.0.97 pin underneath and has not been through the flows. Each was run withrun-flow.mjsand the heartbeat monitor. Earlier, on the previous heads, the E2E Flow Tests workflow passed all 12 flows ("12 flows, 0 failed") on these exact heads: run 38051256122. wire-sysio3597cc6f, wire-libraries-ts53519742, wire-tools-ts6fb42b7d, wire-ethereum4c62fc22, wire-solanaa5a15e4d, wire-cdta00bd718.🤖 Generated with Claude Code
https://claude.ai/code/session_01ARSeK35wwkiAy4et9mCkVm