Repository navigation
Conversation
An underwriter's `bonds` row was the one depot row a batch operator paid RAM for. It exists only against locked bond tokens, at most one per underwriter per request, so the `sysio` pool carries it. An issuer's `requests` and `escrows` rows stay issuer-paid. Change-Id: I4ec67c7cc24ee2f1c73a4be52ffa0d7273b174c8
Change-Id: Icf3edf15882444d519d2e4da940c876217370417
Change-Id: I83a058348c11b9dfbb155eaa6835d40c5f78c69d
valthon
requested changes
Nov 11, 2026
valthon
left a comment
valthon
left a comment
Contributor
There was a problem hiding this comment.
PR description is misleading. Sounds like we're changing the payer for all bond use, but once i got into the code it's clear we're only doing it for privileged accounts (despite removing a critical test). Please fix description and restore the missing test.
Comment on lines
-858
to
+860
| // A bond row bills its underwriter; the request row the accept updates stays the issuer's. | ||
| BOOST_FIXTURE_TEST_CASE(accept_bills_the_underwriter, sysio_bond_tester) try { | ||
| // A bond row bills the sysio RAM pool, never its underwriter; the request row the accept updates | ||
| // stays the issuer's. | ||
| BOOST_FIXTURE_TEST_CASE(accept_bills_sysio, sysio_bond_tester) try { |
Contributor
There was a problem hiding this comment.
I don't love removing the general test, since it should still be applicable. Could you instead create a new test for the privileged account case and keep the old test passing as it was (with the non-privileged user paying)?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sysio.bond::acceptbilled thebondsrow to the underwriter, the only row in the depot a batch operator needed RAM for. It now billssysio, as the other depot contracts' rows do. The row exists only against locked bond tokens and there is at most one per underwriter per request, so it is not a free write.An issuer's
requestsandescrowsrows are unchanged: any account may open a request, with a statement of its own size, so those stay issuer-paid.The ABI is unchanged and
sysio.bond.wasmis rebuilt.Merge before wire-tools-ts
feature/bootstrap-without-t1-node-owner, which stops granting underwriting operators RAM.